beta-nu-theta-chi / ox-dashboard

A chapter dashabord web app in Django for the Beta Nu Chapter of Theta Chi at Case Western Reserve University
MIT License
0 stars 0 forks source link

Chapter Advisor Position #16

Closed DLance96 closed 7 years ago

DLance96 commented 7 years ago

Add a way for our chapter advisor to view everything that the President can view (aka Dan Neuman)

mtbentley commented 7 years ago

I think the best way to do this will be to allow multiple people to hold one position. That way we can also add the VP adviser as VP, treasurer adviser as treasurer, etc.

That should only require changing up the verify_position decorator.

kihashi commented 7 years ago

As a chapter advisor, I would argue that unless there's a compelling reason otherwise, we should have access to everything. I may be the secretary advisor, but most of us are past presidents. We might be able to advise other positions if we have the information.

Love and Respect, John Cleaver

On Sun, Dec 25, 2016, 6:55 PM Matthew notifications@github.com wrote:

I think the best way to do this will be to allow multiple people to hold one position. That way we can also add the VP adviser as VP, treasurer adviser as treasurer, etc.

That should only require changing up the verify_position decorator.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/beta-nu-theta-chi/ox-dashboard/issues/16#issuecomment-269142367, or mute the thread https://github.com/notifications/unsubscribe-auth/AAlPwgMX1XHVYZGaVAsb4ft-z_rgPkzfks5rLwJ8gaJpZM4LVQIm .

mtbentley commented 7 years ago

In #18, the 'Adviser' position now can access everything the president can. However, we might have to look through the bylaws to make sure there's nothing exposed that is confidential to, for example, the president and scholarship chair.

This change will allow multiple people to hold the 'Adviser' position (as well as any other).

DLance96 commented 7 years ago

All that seems fine to me having glanced over the current iteration of the bylaws