search

betacraftuk / betacraft-launcher

A launcher for Minecraft focused on legacy versions of the game
https://betacraft.uk
GNU General Public License v3.0
336 stars 40 forks source link

[BUG] Buttons in menu (possibly ingame) not working when using mods #273

Closed cisc0disco closed 2 months ago

cisc0disco commented 1 year ago

Describe the bug Mouse clicking in menu (maybe ingame too, i was unable to get in the game) is sometimes not recognized and thus i'm unable to click any buttons in the menu when playing with mods where legacyfix overrides some code.

To Reproduce Steps to reproduce the behavior:

  1. Go to menu
  2. Click on any button

Expected behavior Button should be clicked and i actually click

Desktop (please complete the following information):

Additional context I tried it with Better than adventure mod and this started happening

Moresteck commented 1 year ago

This is because BTA handles mouse code in non standard way. I believe they actually fixed macOS mouse by itself, meaning legacyfix is not required. I'll see what can be done to make it easier to disable legacyfix.

cisc0disco commented 1 year ago

Thanks for the reply, i eventually figured out from your source code, that it does that and tried to fix it myself without compiling the code, because i don't do Java, but couldn't do it and told myself that i'd do it when i have free time :D. I can try to do it myself and create PR.

Moresteck commented 2 months ago

Closing due to no activity. BTA should not be launched with legacyfix in the future, it already works well without it.