betacraftuk / betacraft-launcher

A launcher for Minecraft focused on legacy versions of the game
https://betacraft.uk
GNU General Public License v3.0
319 stars 40 forks source link

GTK theme support #298

Open DexrnZacAttack opened 1 year ago

DexrnZacAttack commented 1 year ago

Is your feature request related to a problem? Please describe. No

Describe the solution you'd like Allow theming the launcher using GTK themes, as well as maybe Plasma themes.

Describe alternatives you've considered Building my own version but I'm shit at java so not gonna happen

Additional context image

ghost commented 11 months ago

Building my own version but I'm shit at java so not gonna happen

v2 is made in Qt, C++

Also, aren't the buttons (and tabs) using the GTK theme already?

DexrnZacAttack commented 11 months ago

Not for me it seems, they look like basic breeze buttons…

ghost commented 11 months ago

What about other Qt 6 apps? Do they also use the Breeze theme or the GTK one?

DexrnZacAttack commented 11 months ago

Ah I figured it out, when I typed the last reply I failed to notice the "v2 is made in Qt, C++" part...

I didn't know this at the time when I made my issue... Sorry about that.

DexrnZacAttack commented 11 months ago

Actually, reopening this... is there a way to get the theme shown in this screenshot to work with BCLv2? image Are there QT6 themes or anything like that? I am still kinda new to Linux.

ghost commented 11 months ago

QT themes are a thing, but they're different. As for getting GTK themes working with QT6, you have to research that yourself.

ghost commented 11 months ago

On the latest commit (self-built) my GTK theme seems to be working: Latest commit launcher

On the latest pre-release it does not work however: Latest pre-release launcher

notdevcody commented 7 months ago

When the launcher is built in release mode, it's not picking up things like accent colors and GTK themes. Will look into why this is happening.