search

betacraftuk / betacraft-launcher

A launcher for Minecraft focused on legacy versions of the game
https://betacraft.uk
GNU General Public License v3.0
336 stars 40 forks source link

[BUG] Crashes on game window resize under macos (SIGSEGV) #342

Open benjamingwynn opened 6 months ago

benjamingwynn commented 6 months ago

Describe the bug After launching the game, everything works perfectly. If you resize the window at all, the game crashes instantly.

To Reproduce Steps to reproduce the behavior:

  1. Start the game on macos
  2. Resize the window

Expected behavior The game should not crash when the game window is resized.

Screenshots crash-on-resize

Desktop (please complete the following information):

Additional context I'm running a version of v2 I built today (HEAD is cba404f)

Also referenced here to be affecting version 1.7.3: https://www.reddit.com/r/GoldenAgeMinecraft/comments/1becyxz/betacraft_173_crashing_when_trying_resize_window/

Using Java x64 1.8.0_412 Zulu. Tried with both b1.6.6 and a1.0.1_01 with same result.

Workaround: start with a defined window size instead of resizing the window.

Logs: crash-report.txt hs_err_pid90027.log

I can't actually figure out how to grab show the actual Minecraft client/server logs on v2, I have "Show game log" checked under the instance, but can't figure out where it's supposed to be showing me those logs.

benjamingwynn commented 6 months ago

Interestingly, Prism Launcher does not suffer from this resize bug; but as we know the colours are wrong on Apple Silicon under Prism Screen Recording 2024-06-01 at 02 19 52

benjamingwynn commented 6 months ago

By running Betacraft.app/Contents/MacOS/Betacraft directly via the terminal I was able to get logs, nothing too useful after resize though:

[16:03:49] Files initialized
[16:03:52] /Users/ws/Library/Application Support/minecraft/libraries/legacyfix/legacyfix/202306DEV/legacyfix-202306DEV-agent.jar
[16:03:52] /Users/ws/Library/Application Support/minecraft/libraries/org/lwjgl/lwjgl/lwjgl-platform/2.9.4-nightly-20150209/lwjgl-platform-2.9.4-nightly-20150209-natives-osx-x86.jar
[16:03:52] /Users/ws/Library/Application Support/minecraft/libraries/net/java/jinput/jinput-platform/2.0.5/jinput-platform-2.0.5-natives-osx.jar
[16:03:52] 
assets_root=-Dlf.assetDir=/Users/ws/Library/Application Support/minecraft/assets/
[16:03:52] 
assets_root=-Dlf.assetIndex=/Users/ws/Library/Application Support/minecraft/assets//indexes/${assets_index_name}.json
[16:03:52] /Users/ws/code/betacraft-launcher/build/zulu8.78.0.19-ca-jre8.0.412-macosx_x64/zulu-8.jre/Contents/Home/bin/java
[16:03:52] -Duser.home=/Users/ws/Library/Application Support/betacraft/instances/a1.1/
[16:03:52] -Xmx1G
[16:03:52] -XX:HeapDumpPath=java.exe_minecraft.exe.heapdump
[16:03:52] -Djava.library.path=/Users/ws/Library/Application Support/betacraft/instances/a1.1/natives-915679f7-62ec-1e69-9adf-3656c9ad9ee4/
[16:03:52] -javaagent:/Users/ws/Library/Application Support/betacraft/instances/a1.1/natives-915679f7-62ec-1e69-9adf-3656c9ad9ee4//legacyfix-202306DEV.jar
[16:03:52] -Dminecraft.user.uuid=bd346dd5-ac1c-427d-87e8-73bdd4bf3e13
[16:03:52] -Dlf.frameName=a1.1
[16:03:52] -Dlf.disableControllers
[16:03:52] -Dlf.fixAMD=true
[16:03:52] -Dlf.assetDir=/Users/ws/Library/Application Support/minecraft/assets/
[16:03:52] -Dlf.assetIndex=/Users/ws/Library/Application Support/minecraft/assets//indexes/a1.0.14.json
[16:03:52] -Dlf.icon=/Users/ws/Library/Application Support/betacraft/instances/a1.1/instance_icon.png
[16:03:52] -Dlf.patchMouse
[16:03:52] -Dlf.deAWT
[16:03:52] -Xdock:name=a1.1
[16:03:52] -Xdock:icon=/Users/ws/Library/Application Support/betacraft/instances/a1.1/instance_icon.png
[16:03:52] -Dlf.OVERLAY_OUTER_BODY_TO_BASE
[16:03:52] -Dlf.ROTATE_BOTTOM_TEXTURES
[16:03:52] -Dlf.CONVERT_ALEX_TO_STEVE
[16:03:52] -Dlf.SERVE_AS_64x32
[16:03:52] -Djava.util.Arrays.useLegacyMergeSort=true
[16:03:52] -cp
[16:03:52] /Users/ws/Library/Application Support/betacraft/versions/a1.1.2.jar:/Users/ws/Library/Application Support/minecraft/libraries/com/google/gson/2.8.10-SNAPSHOT/gson-2.8.10-SNAPSHOT.jar:/Users/ws/Library/Application Support/minecraft/libraries/javassist/javassist/3.29.0-SNAPSHOT-20211108/javassist-3.29.0-SNAPSHOT-20211108.jar:/Users/ws/Library/Application Support/minecraft/libraries/uk/betacraft/mcwrapper/20230617/mcwrapper-20230617.jar:/Users/ws/Library/Application Support/minecraft/libraries/legacyfix/legacyfix/202306DEV/legacyfix-202306DEV.jar:/Users/ws/Library/Application Support/minecraft/libraries/legacyfix/legacyfix/202306DEV/legacyfix-202306DEV.jar:/Users/ws/Library/Application Support/minecraft/libraries/net/java/jinput/jinput/2.0.5/jinput-2.0.5.jar:/Users/ws/Library/Application Support/minecraft/libraries/net/java/jutils/jutils/1.0.0/jutils-1.0.0.jar:/Users/ws/Library/Application Support/minecraft/libraries/org/lwjgl/lwjgl/lwjgl/2.9.4-nightly-20150209/lwjgl-2.9.4-nightly-20150209.jar:/Users/ws/Library/Application Support/minecraft/libraries/org/lwjgl/lwjgl/lwjgl_util/2.9.4-nightly-20150209/lwjgl_util-2.9.4-nightly-20150209.jar:/Users/ws/Library/Application Support/minecraft/libraries/org/lwjgl/lwjgl/lwjgl-platform/2.9.4-nightly-20150209/lwjgl-platform-2.9.4-nightly-20150209.jar:/Users/ws/Library/Application Support/minecraft/libraries/net/java/jinput/jinput-platform/2.0.5/jinput-platform-2.0.5.jar
[16:03:52] uk.betacraft.mcwrapper.BCWrapper
[16:03:52] username=Player
[16:03:52] sessionid=token:-:bd346dd5-ac1c-427d-87e8-73bdd4bf3e13
[16:03:52] gameDir=/Users/ws/Library/Application Support/betacraft/instances/a1.1/.minecraft/
[16:03:52] versionName=a1.1.2
[16:03:52] frameName=a1.1
[16:03:52] width=854
[16:03:52] height=480
[16:03:52] demo=true
patchmacmouse - true
fix15a - false
deAWT - true
found mcclas: net.minecraft.client.Minecraft
found appletMode field: l
found canvas class name: h
found match for guiscreen: bh
found resolution: c
found resolution: d
found match for mousehelper: mp
MOUSE Y INVERT: false
Accepted username: Player
Client asked for parameter: fullscreen
Client asked for parameter: username
Client asked for parameter: sessionid
28
Client asked for parameter: username
Client asked for parameter: sessionid
Setting user: Player, token:-:bd346dd5-ac1c-427d-87e8-73bdd4bf3e13
Client asked for parameter: mppass
Client asked for parameter: loadmap_user
Client asked for parameter: server
Applying fixes...
Applying fixes...

Starting up SoundSystem...
Initializing LWJGL OpenAL
    (The LWJGL binding of OpenAL.  For more information, see http://www.lwjgl.org)
OpenAL initialized.

Got http://www.minecraft.net/resources/
[legacyfix] Set XML resource index
[legacyfix] Set TXT resource index
<< user resizes the window >>
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007ff80cc42a1d, pid=27926, tid=0x000000000001f643
#
# JRE version: OpenJDK Runtime Environment (Zulu 8.78.0.19-CA-macosx) (8.0_412-b08) (build 1.8.0_412-b08)
# Java VM: OpenJDK 64-Bit Server VM (25.412-b08 mixed mode bsd-amd64 compressed oops)
# Problematic frame:
# C  [libobjc.A.dylib+0x6a1d]  objc_msgSend+0x1d
#
# Core dump written. Default location: /cores/core or core.27926
#
# An error report file with more information is saved as:
# /Users/ws/Library/Application Support/betacraft/instances/a1.1/hs_err_pid27926.log
#
# If you would like to submit a bug report, please visit:
#   http://www.azul.com/support/
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.

Perhaps this is an issue in the legacyfix mod that's applied via the Betacraft launcher. This would explain why Prism Launcher dosn't have the issue, as it doesn't apply the legacyfix mod.

Moresteck commented 6 months ago

To clarify, this has nothing to do with legacyfix. The issue affects all versions depending on LWJGL2. Try running 1.12.2 in Prism or the official launcher — the same crash will happen.

See my response in #38 for more context

benjamingwynn commented 6 months ago

Hey @Moresteck, thanks for getting back to me and for all the work you've done on Betacraft! :tada:

Via Prism launcher, if I run 1.12.2 using ARM Java it doesn't crash on resize, but x86 java does.

It's using LWJGL 2.9.4-nightly-20150209 which seems to be the same version.

However, if I switch over to using ARM Java on Betacraft launcher, it immediately crashes on startup:

Exception in thread "Minecraft main thread" java.lang.NoClassDefFoundError: Could not initialize class org.lwjgl.opengl.Display
    at net.minecraft.client.Minecraft.a(SourceFile:157)
    at net.minecraft.client.Minecraft.run(SourceFile:554)
    at java.lang.Thread.run(Thread.java:750)
Exception in thread "Thread-2" java.lang.NoClassDefFoundError: Could not initialize class org.lwjgl.opengl.Display
    at legacyfix.ResizeThread.run(ResizeThread.java)
Moresteck commented 6 months ago

Couldn't reproduce not crashing on Prism with 1.12.2 and ARM64 Java. I used Zulu 8u411 (aarch64)

Thread 0:: Dispatch queue: com.apple.main-thread 0 libobjc.A.dylib 0x19b1cdc34 objc_msgSend + 52 1 AppleMetalOpenGLRenderer 0x116737cec GLRDrawable::attachDrawable(GLDContextRec, unsigned int, GLDDrawableRec, unsigned int, GLTDimensionsRec, GLRDrawable const) + 332 2 AppleMetalOpenGLRenderer 0x11673a080 gldAttachDrawable + 580 3 GLEngine 0x1f248ddb8 gliAttachDrawableWithOptions + 252 4 OpenGL 0x1f22877c4 0x1f2283000 + 18372 5 OpenGL 0x1f22885b8 CGLSetVirtualScreen + 128 6 AppKit 0x19f5fb0ec NSOpenGLContextUpdateOffScreenViewSurface + 504 7 AppKit 0x19f18f198 -[NSOpenGLContext update] + 344 8 CoreFoundation 0x19b677144 CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER + 148 9 CoreFoundation 0x19b70b3d8 _CFXRegistrationPost_block_invoke + 88 10 CoreFoundation 0x19b70b320 _CFXRegistrationPost + 440 11 CoreFoundation 0x19b645678 _CFXNotificationPost + 768 12 Foundation 0x19c7624e4 -[NSNotificationCenter postNotificationName:object:userInfo:] + 88 13 CoreFoundation 0x19b677144 CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER + 148 14 CoreFoundation 0x19b70b3d8 _CFXRegistrationPost_block_invoke + 88 15 CoreFoundation 0x19b70b320 _CFXRegistrationPost + 440 16 CoreFoundation 0x19b645678 _CFXNotificationPost + 768 17 Foundation 0x19c7624e4 -[NSNotificationCenter postNotificationName:object:userInfo:] + 88 18 AppKit 0x19eefdb28 NSViewHierarchyNoteGeometryInWindowDidChange + 156 19 AppKit 0x19eefdbcc NSViewHierarchyNoteGeometryInWindowDidChange + 320 20 AppKit 0x19eefd9e4 -[NSView _invalidateFocus] + 68 21 AppKit 0x19ef0b2e8 -[NSView setFrameSize:] + 1632 22 AppKit 0x19ef24f3c -[NSThemeFrame setFrameSize:] + 244 23 AppKit 0x19ef248a0 -[NSWindow _oldPlaceWindow:fromServer:] + 532 24 AppKit 0x19ef23d5c -[NSWindow _setFrameCommon:display:fromServer:] + 1832 25 AppKit 0x19f1bd3ec -[NSWindow(NSWindowResizing) _resizeWithEvent:] + 1652 26 AppKit 0x19f0dc2e4 -[NSTitledFrame attemptResizeWithEvent:] + 156 27 AppKit 0x19f0dc0fc -[NSThemeFrame handleMouseDown:] + 196 28 AppKit 0x19f152894 -[NSThemeFrame mouseDown:] + 32 29 AppKit 0x19f080dcc -[NSWindow(NSEventRouting) _handleMouseDownEvent:isDelayedEvent:] + 3472 30 AppKit 0x19f00c40c -[NSWindow(NSEventRouting) _reallySendEvent:isDelayedEvent:] + 288 31 AppKit 0x19f00c118 -[NSWindow(NSEventRouting) sendEvent:] + 284 32 AppKit 0x19f6d4828 -[NSApplication(NSEventRouting) sendEvent:] + 1604 33 libosxapp.dylib 0x11200439c -[NSApplicationAWT sendEvent:] + 292 34 AppKit 0x19f32289c -[NSApplication _handleEvent:] + 60 35 AppKit 0x19eed30c0 -[NSApplication run] + 512 36 libosxapp.dylib 0x112004038 +[NSApplicationAWT runAWTLoopWithApp:] + 184 37 libawt_lwawt.dylib 0x1123a630c +[AWTStarter starter:headless:] + 500 38 libosxapp.dylib 0x112005c20 +[ThreadUtilities invokeBlockCopy:] + 28 39 Foundation 0x19c7d23f4 NSThreadPerformPerform + 264 40 CoreFoundation 0x19b6824d8 CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION + 28 41 CoreFoundation 0x19b68246c CFRunLoopDoSource0 + 176 42 CoreFoundation 0x19b6821dc CFRunLoopDoSources0 + 244 43 CoreFoundation 0x19b680dc8 CFRunLoopRun + 828 44 CoreFoundation 0x19b680434 CFRunLoopRunSpecific + 608 45 java 0x102d8822c CreateExecutionEnvironment + 824 46 java 0x102d84af8 JLI_Launch + 1576 47 java 0x102d8aa38 main + 76 48 dyld 0x19b21a0e0 start + 2360

As for Betacraft crashing with ARM64 Java, that's because we source jsons for versions past 1.7.7 from the official launcher, and they don't have ARM64 natives included. As of now, only b1.7.3 is ARM64 aware.

Moresteck commented 6 months ago

I have "Show game log" checked under the instance, but can't figure out where it's supposed to be showing me those logs.

Oh, and as for that, I think the ongoing refactor broke the "Show game log" & "Keep the launcher open" options

benjamingwynn commented 6 months ago

So I think I'm seeing the same results as you, but I'm seeing different results on different versions of the game, I think it could perhaps go beyond LWJGL versions since as far as I can tell all of these tests use the same version

Prism Launcher ARM

1.12.2 via Prism Launcher, ARM Java 8 /Library/Java/JavaVirtualMachines/zulu-8.jre/Contents/Home/bin/java - lwjgl 2.9.4-nightly-20150209 - i'd say a 50% chance of crash:

Screen Recording 2024-06-03 at 16 52 24

a1.0.4 via Prism launcher, ARM Java 8 /Library/Java/JavaVirtualMachines/zulu-8.jre/Contents/Home/bin/java, lwjgl 2.9.4-nightly-20150209 - never crashes:

Screen Recording 2024-06-03 at 16 55 40

Prism Launcher x86

1.12.2 via Prism Launcher, x86 Java 8 /Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home/bin/java - lwjgl 2.9.4-nightly-20150209 - redrew maybe a frame before crashing:

Screen Recording 2024-06-03 at 16 58 05

a.1.0.4 via Prism Launcher, x86 Java 8 /Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home/bin/java - lwjgl 2.9.4-nightly-20150209 - never crashes:

Screen Recording 2024-06-03 at 17 00 12

Betacraft Launcher ARM

1.12.2 via BCL, ARM Java 8 /Library/Java/JavaVirtualMachines/zulu-8.jre/Contents/Home/bin/java

Refuses to start

Screen Recording 2024-06-03 at 17 06 17

a1.0.4 via BCL, ARM Java 8 /Library/Java/JavaVirtualMachines/zulu-8.jre/Contents/Home/bin/java

Crashes instantly, but doesn't refuse to start (might be a different bug):

[17:07:20] Files initialized
[17:07:20] openjdk version "1.8.0_292"

[17:08:38] /Users/ws/Library/Application Support/minecraft/libraries/legacyfix/legacyfix/202306DEV/legacyfix-202306DEV-agent.jar
[17:08:38] /Users/ws/Library/Application Support/minecraft/libraries/org/lwjgl/lwjgl/lwjgl-platform/2.9.4-nightly-20150209/lwjgl-platform-2.9.4-nightly-20150209-natives-osx-x86.jar
[17:08:38] /Users/ws/Library/Application Support/minecraft/libraries/net/java/jinput/jinput-platform/2.0.5/jinput-platform-2.0.5-natives-osx.jar
[17:08:39] 
assets_root=-Dlf.assetDir=/Users/ws/Library/Application Support/minecraft/assets/
[17:08:39] 
assets_root=-Dlf.assetIndex=/Users/ws/Library/Application Support/minecraft/assets//indexes/${assets_index_name}.json
[17:08:39] /Library/Java/JavaVirtualMachines/zulu-8.jre/Contents/Home/bin/java
[17:08:39] -Duser.home=/Users/ws/Library/Application Support/betacraft/instances/alpha/
[17:08:39] -Xmx1G
[17:08:39] -XX:HeapDumpPath=java.exe_minecraft.exe.heapdump
[17:08:39] -Djava.library.path=/Users/ws/Library/Application Support/betacraft/instances/alpha/natives-bec99c69-c461-ab85-5276-bc47d09a516e/
[17:08:39] -javaagent:/Users/ws/Library/Application Support/betacraft/instances/alpha/natives-bec99c69-c461-ab85-5276-bc47d09a516e//legacyfix-202306DEV.jar
[17:08:39] -Dminecraft.user.uuid=bd346dd5-ac1c-427d-87e8-73bdd4bf3e13
[17:08:39] -Dlf.frameName=alpha
[17:08:39] -Dlf.disableControllers
[17:08:39] -Dlf.fixAMD=true
[17:08:39] -Dlf.assetDir=/Users/ws/Library/Application Support/minecraft/assets/
[17:08:39] -Dlf.assetIndex=/Users/ws/Library/Application Support/minecraft/assets//indexes/a1.0.3.json
[17:08:39] -Dlf.icon=/Users/ws/Library/Application Support/betacraft/instances/alpha/instance_icon.png
[17:08:39] -Dlf.patchMouse
[17:08:39] -Dlf.deAWT
[17:08:39] -Xdock:name=alpha
[17:08:39] -Xdock:icon=/Users/ws/Library/Application Support/betacraft/instances/alpha/instance_icon.png
[17:08:39] -Dlf.OVERLAY_OUTER_BODY_TO_BASE
[17:08:39] -Dlf.ROTATE_BOTTOM_TEXTURES
[17:08:39] -Dlf.CONVERT_ALEX_TO_STEVE
[17:08:39] -Dlf.SERVE_AS_64x32
[17:08:39] -Djava.util.Arrays.useLegacyMergeSort=true
[17:08:39] -cp
[17:08:39] /Users/ws/Library/Application Support/betacraft/versions/a1.0.4.jar:/Users/ws/Library/Application Support/minecraft/libraries/com/google/gson/2.8.10-SNAPSHOT/gson-2.8.10-SNAPSHOT.jar:/Users/ws/Library/Application Support/minecraft/libraries/javassist/javassist/3.29.0-SNAPSHOT-20211108/javassist-3.29.0-SNAPSHOT-20211108.jar:/Users/ws/Library/Application Support/minecraft/libraries/uk/betacraft/mcwrapper/20230617/mcwrapper-20230617.jar:/Users/ws/Library/Application Support/minecraft/libraries/legacyfix/legacyfix/202306DEV/legacyfix-202306DEV.jar:/Users/ws/Library/Application Support/minecraft/libraries/legacyfix/legacyfix/202306DEV/legacyfix-202306DEV.jar:/Users/ws/Library/Application Support/minecraft/libraries/net/java/jinput/jinput/2.0.5/jinput-2.0.5.jar:/Users/ws/Library/Application Support/minecraft/libraries/net/java/jutils/jutils/1.0.0/jutils-1.0.0.jar:/Users/ws/Library/Application Support/minecraft/libraries/org/lwjgl/lwjgl/lwjgl/2.9.4-nightly-20150209/lwjgl-2.9.4-nightly-20150209.jar:/Users/ws/Library/Application Support/minecraft/libraries/org/lwjgl/lwjgl/lwjgl_util/2.9.4-nightly-20150209/lwjgl_util-2.9.4-nightly-20150209.jar:/Users/ws/Library/Application Support/minecraft/libraries/org/lwjgl/lwjgl/lwjgl-platform/2.9.4-nightly-20150209/lwjgl-platform-2.9.4-nightly-20150209.jar:/Users/ws/Library/Application Support/minecraft/libraries/net/java/jinput/jinput-platform/2.0.5/jinput-platform-2.0.5.jar
[17:08:39] uk.betacraft.mcwrapper.BCWrapper
[17:08:39] username=Player
[17:08:39] sessionid=token:-:bd346dd5-ac1c-427d-87e8-73bdd4bf3e13
[17:08:39] gameDir=/Users/ws/Library/Application Support/betacraft/instances/alpha/.minecraft/
[17:08:39] versionName=a1.0.4
[17:08:39] frameName=alpha
[17:08:39] width=2560
[17:08:39] height=1440
[17:08:39] demo=true
patchmacmouse - true
fix15a - false
deAWT - true
found mcclas: ax
found appletMode field: l
found canvas class name: s
found match for guiscreen: dg
found resolution: c
found resolution: d
java.lang.UnsatisfiedLinkError: /Users/ws/Library/Application Support/betacraft/instances/alpha/natives-bec99c69-c461-ab85-5276-bc47d09a516e/liblwjgl.dylib: dlopen(/Users/ws/Library/Application Support/betacraft/instances/alpha/natives-bec99c69-c461-ab85-5276-bc47d09a516e/liblwjgl.dylib, 0x0001): tried: '/Users/ws/Library/Application Support/betacraft/instances/alpha/natives-bec99c69-c461-ab85-5276-bc47d09a516e/liblwjgl.dylib' (fat file, but missing compatible architecture (have 'x86_64', need 'arm64e' or 'arm64')), '/System/Volumes/Preboot/Cryptexes/OS/Users/ws/Library/Application Support/betacraft/instances/alpha/natives-bec99c69-c461-ab85-5276-bc47d09a516e/liblwjgl.dylib' (no such file), '/Users/ws/Library/Application Support/betacraft/instances/alpha/natives-bec99c69-c461-ab85-5276-bc47d09a516e/liblwjgl.dylib' (fat file, but missing compatible architecture (have 'x86_64', need 'arm64e' or 'arm64'))
    at java.lang.ClassLoader$NativeLibrary.load(Native Method)
    at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1950)
    at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1865)
    at java.lang.Runtime.loadLibrary0(Runtime.java:844)
    at java.lang.System.loadLibrary(System.java:1136)
    at org.lwjgl.Sys$1.run(Sys.java:72)
    at java.security.AccessController.doPrivileged(Native Method)
    at org.lwjgl.Sys.doLoadLibrary(Sys.java:66)
    at org.lwjgl.Sys.loadLibrary(Sys.java:96)
    at org.lwjgl.Sys.<clinit>(Sys.java:117)
    at org.lwjgl.opengl.Display.<clinit>(Display.java:135)
    at java.lang.Class.forName0(Native Method)
    at java.lang.Class.forName(Class.java:264)
    at legacyfix.agent.LegacyFixAgent.premain(LegacyFixAgent.java:176)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at sun.instrument.InstrumentationImpl.loadClassAndStartAgent(InstrumentationImpl.java:386)
    at sun.instrument.InstrumentationImpl.loadClassAndCallPremain(InstrumentationImpl.java:401)
Accepted username: Player
Client asked for parameter: fullscreen
Client asked for parameter: username
Client asked for parameter: sessionid
28
Client asked for parameter: username
Client asked for parameter: sessionid
Client asked for parameter: mppass
Client asked for parameter: loadmap_user
Client asked for parameter: server
Exception in thread "Minecraft main thread" java.lang.NoClassDefFoundError: Could not initialize class org.lwjgl.opengl.Display
    at ax.a(SourceFile:149)
    at ax.run(SourceFile:541)
    at java.lang.Thread.run(Thread.java:750)
Exception in thread "Thread-2" java.lang.NoClassDefFoundError: Could not initialize class org.lwjgl.opengl.Display
    at legacyfix.ResizeThread.run(ResizeThread.java)
Applying fixes...

Betacraft Launcher x86

Trying to play 1.12.2 When I use /Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home/bin/java or /usr/bin/java, it crashes immediatley at launch.

[17:12:04] /Users/ws/Library/Application Support/minecraft/libraries/org/lwjgl/lwjgl/lwjgl-platform/2.9.2-nightly-20140822/lwjgl-platform-2.9.2-nightly-20140822-natives-osx.jar
[17:12:04] /Users/ws/Library/Application Support/minecraft/libraries/net/java/jinput/jinput-platform/2.0.5/jinput-platform-2.0.5-natives-osx.jar
[17:12:04] /Users/ws/Library/Application Support/minecraft/libraries/ca/weblite/java-objc-bridge/1.0.0/java-objc-bridge-1.0.0-natives-osx.jar
[17:12:04] /Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home/bin/java
[17:12:04] -Duser.home=/Users/ws/Library/Application Support/betacraft/instances/1.12.1/
[17:12:04] -Xmx1G
[17:12:04] -XX:HeapDumpPath=java.exe_minecraft.exe.heapdump
[17:12:04] -Djava.library.path=/Users/ws/Library/Application Support/betacraft/instances/1.12.1/natives-d7533909-2374-fa54-ba35-9e123234b5af/
[17:12:04] -Dminecraft.launcher.brand=Betacraft
[17:12:04] -Dminecraft.launcher.version=2.0.0-alpha.20230623
[17:12:04] -cp
[17:12:04] /Users/ws/Library/Application Support/betacraft/versions/1.12.2.jar:/Users/ws/Library/Application Support/minecraft/libraries/com/mojang/patchy/1.3.9/patchy-1.3.9.jar:/Users/ws/Library/Application Support/minecraft/libraries/oshi-project/oshi-core/1.1/oshi-core-1.1.jar:/Users/ws/Library/Application Support/minecraft/libraries/net/java/dev/jna/jna/4.4.0/jna-4.4.0.jar:/Users/ws/Library/Application Support/minecraft/libraries/net/java/dev/jna/platform/3.4.0/platform-3.4.0.jar:/Users/ws/Library/Application Support/minecraft/libraries/com/ibm/icu/icu4j-core-mojang/51.2/icu4j-core-mojang-51.2.jar:/Users/ws/Library/Application Support/minecraft/libraries/net/sf/jopt-simple/jopt-simple/5.0.3/jopt-simple-5.0.3.jar:/Users/ws/Library/Application Support/minecraft/libraries/com/paulscode/codecjorbis/20101023/codecjorbis-20101023.jar:/Users/ws/Library/Application Support/minecraft/libraries/com/paulscode/codecwav/20101023/codecwav-20101023.jar:/Users/ws/Library/Application Support/minecraft/libraries/com/paulscode/libraryjavasound/20101123/libraryjavasound-20101123.jar:/Users/ws/Library/Application Support/minecraft/libraries/com/paulscode/librarylwjglopenal/20100824/librarylwjglopenal-20100824.jar:/Users/ws/Library/Application Support/minecraft/libraries/com/paulscode/soundsystem/20120107/soundsystem-20120107.jar:/Users/ws/Library/Application Support/minecraft/libraries/io/netty/netty-all/4.1.9.Final/netty-all-4.1.9.Final.jar:/Users/ws/Library/Application Support/minecraft/libraries/com/google/guava/guava/21.0/guava-21.0.jar:/Users/ws/Library/Application Support/minecraft/libraries/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar:/Users/ws/Library/Application Support/minecraft/libraries/commons-io/commons-io/2.5/commons-io-2.5.jar:/Users/ws/Library/Application Support/minecraft/libraries/commons-codec/commons-codec/1.10/commons-codec-1.10.jar:/Users/ws/Library/Application Support/minecraft/libraries/net/java/jinput/jinput/2.0.5/jinput-2.0.5.jar:/Users/ws/Library/Application Support/minecraft/libraries/net/java/jutils/jutils/1.0.0/jutils-1.0.0.jar:/Users/ws/Library/Application Support/minecraft/libraries/com/google/code/gson/gson/2.8.0/gson-2.8.0.jar:/Users/ws/Library/Application Support/minecraft/libraries/com/mojang/authlib/1.5.25/authlib-1.5.25.jar:/Users/ws/Library/Application Support/minecraft/libraries/com/mojang/realms/1.10.22/realms-1.10.22.jar:/Users/ws/Library/Application Support/minecraft/libraries/org/apache/commons/commons-compress/1.8.1/commons-compress-1.8.1.jar:/Users/ws/Library/Application Support/minecraft/libraries/org/apache/httpcomponents/httpclient/4.3.3/httpclient-4.3.3.jar:/Users/ws/Library/Application Support/minecraft/libraries/commons-logging/commons-logging/1.1.3/commons-logging-1.1.3.jar:/Users/ws/Library/Application Support/minecraft/libraries/org/apache/httpcomponents/httpcore/4.3.2/httpcore-4.3.2.jar:/Users/ws/Library/Application Support/minecraft/libraries/it/unimi/dsi/fastutil/7.1.0/fastutil-7.1.0.jar:/Users/ws/Library/Application Support/minecraft/libraries/org/apache/logging/log4j/log4j-api/2.8.1/log4j-api-2.8.1.jar:/Users/ws/Library/Application Support/minecraft/libraries/org/apache/logging/log4j/log4j-core/2.8.1/log4j-core-2.8.1.jar:/Users/ws/Library/Application Support/minecraft/libraries/org/lwjgl/lwjgl/lwjgl/2.9.2-nightly-20140822/lwjgl-2.9.2-nightly-20140822.jar:/Users/ws/Library/Application Support/minecraft/libraries/org/lwjgl/lwjgl/lwjgl_util/2.9.2-nightly-20140822/lwjgl_util-2.9.2-nightly-20140822.jar:/Users/ws/Library/Application Support/minecraft/libraries/org/lwjgl/lwjgl/lwjgl-platform/2.9.2-nightly-20140822/lwjgl-platform-2.9.2-nightly-20140822.jar:/Users/ws/Library/Application Support/minecraft/libraries/net/java/jinput/jinput-platform/2.0.5/jinput-platform-2.0.5.jar:/Users/ws/Library/Application Support/minecraft/libraries/com/mojang/text2speech/1.10.3/text2speech-1.10.3.jar:/Users/ws/Library/Application Support/minecraft/libraries/com/mojang/text2speech/1.10.3/text2speech-1.10.3.jar:/Users/ws/Library/Application Support/minecraft/libraries/ca/weblite/java-objc-bridge/1.0.0/java-objc-bridge-1.0.0.jar:/Users/ws/Library/Application Support/minecraft/libraries/ca/weblite/java-objc-bridge/1.0.0/java-objc-bridge-1.0.0.jar
[17:12:04] net.minecraft.client.main.Main
[17:12:04] --demo
[17:12:04] --width
[17:12:04] 854
[17:12:04] --height
[17:12:04] 480
[17:12:04] 
Exception in thread "main" joptsimple.MissingRequiredOptionsException: Missing required option(s) [accessToken, version]
    at joptsimple.OptionParser.ensureRequiredOptions(OptionParser.java:426)
    at joptsimple.OptionParser.parse(OptionParser.java:400)
    at net.minecraft.client.main.Main.main(SourceFile:51)

Screen Recording 2024-06-03 at 17 17 22

Trying to play 1.12.2 with a copy of zulu8.78.0.19-ca-jre8.0.412-macosx_x64 in my home folder also results in the above.

Trying to play a1.0.4 with any of the x86 java versions works, but resizing is broken as initially reported: Screen Recording 2024-06-03 at 17 23 53

As for Betacraft crashing with ARM64 Java, that's because we source jsons for versions past 1.7.7 from the official launcher, and they don't have ARM64 natives included. As of now, only b1.7.3 is ARM64 aware.

Above you can see that Prism can launch older versions of the game under ARM Java and, I guess, uses different natives to do this

Is it possible to use those same natives for Betacraft Launcher? That might fix resize on older versions and would certainly improve performance by not needing to use Rosetta 2

Logs for Prism a1.0.4 which includes the natives it usees:

[...]
(instance name is 1.0 but its a1.0.4 sorry for any confusion in these logs)

Java path is:
/Library/Java/JavaVirtualMachines/zulu-8.jre/Contents/Home/bin/java

Checking Java version...
Java is version 1.8.0_412, using 64 (aarch64) architecture, from Azul Systems, Inc..

Main Class:
  ax

Native path:
  /Users/Shared/PrismLauncher/instances/1.0/natives

Traits:
traits legacyLaunch
traits no-texturepacks
traits legacyServices

Libraries:
  /Users/Shared/PrismLauncher/libraries/net/java/jinput/jinput/2.0.5/jinput-2.0.5.jar
  /Users/Shared/PrismLauncher/libraries/net/java/jutils/jutils/1.0.0/jutils-1.0.0.jar
  /Users/Shared/PrismLauncher/libraries/org/lwjgl/lwjgl/lwjgl/2.9.4-nightly-20150209/lwjgl-2.9.4-nightly-20150209.jar
  /Users/Shared/PrismLauncher/libraries/org/lwjgl/lwjgl/lwjgl_util/2.9.4-nightly-20150209/lwjgl_util-2.9.4-nightly-20150209.jar
  /Users/Shared/PrismLauncher/libraries/com/mojang/minecraft/a1.0.4/minecraft-a1.0.4-client.jar

Native libraries:
  /Users/Shared/PrismLauncher/libraries/net/java/jinput/jinput-platform/2.0.5/jinput-platform-2.0.5-natives-osx-arm64.jar
  /Users/Shared/PrismLauncher/libraries/org/lwjgl/lwjgl/lwjgl-platform/2.9.4-nightly-20150209/lwjgl-platform-2.9.4-nightly-20150209-natives-osx-arm64.jar

Params:
    --gameDir /Users/Shared/PrismLauncher/instances/1.0/.minecraft --assetsDir /Users/Shared/PrismLauncher/instances/1.0/.minecraft/resources --tweakClass net.minecraft.launchwrapper.AlphaVanillaTweaker

Window size: 854 x 480

Launcher: legacy

Java Arguments:
[-Djava.util.Arrays.useLegacyMergeSort=true, -Xdock:icon=icon.png, -Xdock:name="Prism Launcher: 1.0", -Xms512m, -Xmx11200m, -Duser.language=en]

[...]
benjamingwynn commented 6 months ago

That's quite a long comment in hindsight, hopefully there's some useful nuggests of information in there!

Moresteck commented 6 months ago

That's some very thorough documentation! I'm impressed.

The reason older versions don't crash on Prism is because Prism doesn't make them run without the Java applet. Legacyfix does that (in order to fix the BGR issue), and if you were to apply legacyfix on Prism for these versions, you'd observe the same behavior. As long as these versions are displayed inside a Java frame, they don't crash. But when you make them run in standalone mode (LWJGL2 frame), they crash on resize. Now that I think about it, I don't think I've made myself clear the first time :X

Prism's natives sadly don't fix the underlying issue causing the crash...

benjamingwynn commented 6 months ago

This is kind of off topic but I wanted to document this somewhere. (perhaps more relevant to #206)

I'm able to use Prism Launcher with the BGR patch on alpha (a1.0.4 and a1.2.6 tested) with ARM Java 8 (/Library/Java/JavaVirtualMachines/zulu-8.jre/Contents/Home/bin/java) by checking out 7ff1a85 on stable branch of the legacyfix repo and building it myself. Newer versions of legacyfix (both stable/development) seem to have lost the fix for opening inventory/menus crashing the game, even if I set the javaagent to the exact same one betacraft is using (-javaagent:/Users/ws/Library/Application Support/betacraft/instances/alpha/natives-63b17377-ac0d-de13-8d7d-da54ecb211f9//legacyfix-202306DEV.jar on my system) it still crashes after pressing I/Escape in game.

So compile/build 7ff1a85, then I'm then running with: -javaagent:"/Users/ws/code/legacyfix-stable/build/libs/legacyfix.jar" -Dlf.disableControllers -Dlf.fixAMD=true -Dlf.patchMouse -Dlf.deAWT -Dlf.OVERLAY_OUTER_BODY_TO_BASE -Dlf.ROTATE_BOTTOM_TEXTURES -Dlf.CONVERT_ALEX_TO_STEVE -Dlf.SERVE_AS_64x32 -Djava.util.Arrays.useLegacyMergeSort=true - which I stole from Betacrafts logs - some of which is probably redundant

This doesn't fix the window resize issue, but being able to run the original Alphas under ARM allows me to play with Far rendering and Fancy graphics, >60fps @ 4k on my M1 Max chip - which is ideal for me. Prism also seems to have an option to start fullscreen (although it may not work with Alpha, haven't tried it yet)

Moresteck commented 6 months ago

@benjamingwynn That's good to hear. You might fix the issue of inventory opening by adding -Dlf.patchMouse to JVM arguments.

benjamingwynn commented 6 months ago

@Moresteck I used the same arguments for all versions of legacyfix and just changed the javaagent for which build I was using. Only building 7ff1a85 worked for me, which I saw somewhere online (can't remember where sorry)

Moresteck commented 6 months ago

Hm. I just noticed you did include -Dlf.patchMouse last time. I replicated the exact conditions you presented, and I can't reproduce your issue on Prism with the latest stable commit of legacyfix.

Edit: Oh yeah, I see what it is now! You didn't add the Gson library to your minecraft.jar

benjamingwynn commented 5 months ago

@Moresteck oh that makes sense duh! thank you! I'll give it a shot next time I have a chance to play more alpha mc 😄

as for the original bug, it's outside my wheelhouse but I'm hoping there's enough info here for someone to eventually tracedown and fix