search

betaflight / betaflight-configurator

Cross platform configuration tool for the Betaflight firmware
GNU General Public License v3.0
2.52k stars 895 forks source link

FPort telemetry not working after cloud build #3796

Closed TheIsotopes closed 7 months ago

TheIsotopes commented 7 months ago

Describe the bug

since #3726 the fport telemetry is no longer working

As you can see, the entry for the telemetry protocol is missing in the cloud build -> buildlog

After entering the telemetry protocol in the custom defines line it works again -> buildlog

There is no automatic setting of the telemetry protocol as it works with the ghost protocol.

@haslinghuis pls can you check this

To Reproduce

see describe the bug

Expected behavior

insert telemetry protocol for fport radio protocol in cloud build

Configurator version

latest master

Flight controller configuration

No response

Add any other context about the problem that you think might be relevant here

No response

haslinghuis commented 7 months ago

@blckmn cloud build is adding telemetry for CRSF and GHST as we don't add them in common*.h

Please add USE_TELEMETRY_SMARTPORT if USE_SERIALRX_FPORT is defined.

nerdCopter commented 7 months ago

@blckmn , i realize that comments were in different places. was this rectified in the backend yet?

blckmn commented 7 months ago

This is now sorted.