search

betaflight / betaflight-configurator

Cross platform configuration tool for the Betaflight firmware
GNU General Public License v3.0
2.37k stars 855 forks source link

Telemetry slider appears twice #3920

Closed hydra closed 2 weeks ago

hydra commented 2 weeks ago

Describe the bug

image

To Reproduce

Flash SPRacingH7RF binary, view receiver tab.

The exact binary used for testing was the one from the SPRacingH7RF with PixelOSDSupport from here: https://github.com/betaflight/betaflight/pull/13603#issuecomment-2082342485

Expected behavior

Only one slider for telemetry.

Configurator version

master - cd25abfa033e2979102f57e601e0a2d109bc0980

Flight controller configuration

# version
# Betaflight / STM32H730 (SP7R) 4.5.0 Apr 29 2024 / 12:01:30 (17c4fe0c6a) MSP API: 1.46
# config rev: 53c4a3c

# start the command batch
batch start

board_name SPRACINGH7RF
manufacturer_id SPRO

# aux
aux 0 40 0 1300 1700 0 0

# master
set osd_vbat_pos = 2443
set osd_rssi_pos = 353
set osd_link_quality_pos = 2369
set osd_rssi_dbm_pos = 2401
set osd_tim_1_pos = 2433
set osd_ah_sbar_pos = 2254
set osd_ah_pos = 2126
set osd_current_pos = 2411
set osd_craft_name_pos = 2121
set osd_altitude_pos = 2421
set osd_core_temp_pos = 2456
set debug_mode = RX_EXPRESSLRS_SPI
set vtx_band = 1
set vtx_channel = 8
set vtx_power = 1
set expresslrs_uid = 0,0,68,83,145,153

profile 0

rateprofile 0

# end the command batch
batch end

Add any other context about the problem that you think might be relevant here

No response

hydra commented 2 weeks ago

Also happens using offical build:

# version
# Betaflight / STM32H730 (SP7R) 4.5.0 Apr 28 2024 / 21:10:35 (c155f5830) MSP API: 1.46
# config rev: 53c4a3c
# board: manufacturer_id: SPRO, board_name: SPRACINGH7RF

# status
MCU H730 Clock=520MHz, Vref=3.31V, Core temp=56degC
Stack size: 2048, Stack address: 0x20020000
Configuration: CONFIGURED, size: 3927, max available: 65536
Devices detected: SPI:1, I2C:1
Gyros detected: gyro 1 locked
GYRO=ICM42605, ACC=ICM42605, BARO=BMP388
OSD: MSP (30 x 13)
BUILD KEY: 5247170bc70d47594bc49eec6d8be5af (4.5.0)
System Uptime: 49 seconds, Current Time: 2024-04-29T10:23:15.024+00:00
CPU:43%, cycle time: 124, GYRO rate: 8064, RX rate: 500, System rate: 9
Voltage: 1196 * 0.01V (3S battery - OK)
I2C Errors: 9
SD card: Manufacturer 0x27, 30289920kB, 01/2005, v6.0, 'SD32G'
Filesystem: Ready
GPS: NOT ENABLED
Arming disable flags: CLI MSP NO_ACC_CAL
haslinghuis commented 2 weeks ago

Cannot reproduce

# version
# Betaflight / STM32H730 (SP7R) 4.5.0 Apr 29 2024 / 10:43:20 (c155f5830) MSP API: 1.46
# config rev: 53c4a3c
# board: manufacturer_id: SPRO, board_name: SPRACINGH7RF

# status
MCU H730 Clock=520MHz, Vref=3.30V, Core temp=48degC
Stack size: 2048, Stack address: 0x20020000
Configuration: CONFIGURED, size: 3554, max available: 65536
Devices detected: SPI:1, I2C:1
Gyros detected: gyro 1 locked
GYRO=ICM42688P, ACC=ICM42688P, BARO=BMP388
OSD: MSP (53 x 20)
BUILD KEY: 45e82ec2ee12bc127146fd2c723a8739 (4.5.0)
System Uptime: 126 seconds, Current Time: 2024-04-29T10:46:50.167+00:00
CPU:31%, cycle time: 124, GYRO rate: 8064, RX rate: 15, System rate: 9
Voltage: 282 * 0.01V (0S battery - INIT)
I2C Errors: 9
SD card: Manufacturer 0x3, 31166976kB, 01/2007, v8.5, 'SD32G'
Filesystem: Ready
GPS: NOT ENABLED
Arming disable flags: RXLOSS CLI MSP

image

hydra commented 2 weeks ago

Cannot reproduce

You're not using the same verson of the configurator. bae6c8fa from your screenshot is an unknown commit here.

image

From my git log:

$ git log
commit cd25abfa033e2979102f57e601e0a2d109bc0980 (HEAD -> master, origin/master, origin/HEAD)
Author: Míguel Ángel Mulero Martínez <mcgivergim@gmail.com>
Date:   Sun Apr 28 20:29:23 2024 +0200

    Update yarn.lock versions (#3872)

commit 18eb8dd1b20a721fd1ec082d1ac306bb1f9b6d6d
Author: Tomas Chmelevskij <chmelevskij@users.noreply.github.com>
Date:   Sun Apr 28 19:51:41 2024 +0200

    Feat/web virtual mode (#3882)

    * feat: add virtual mode on web

    * feat: only show msp virtual version on virtual mode selection

    * feat: update port selection to update the options

commit 8499939bdf42180aa617daeb757cf7f04e4ed5a7
Author: Mark Haslinghuis <mark@numloq.nl>
Date:   Sun Apr 28 03:50:01 2024 +0200

    Update version to 11.0 (#3873)

commit c97deaf7146837b2378e683a7f5b429fea34d5a9 (tag: 10.10.0)
Author: Mark Haslinghuis <mark@numloq.nl>
Date:   Sat Apr 27 21:53:13 2024 +0200

    Fix Angle Mode positioning (#3914)
hydra commented 2 weeks ago

Also, here's a build log, including removal of generated artifacts.

Hydra on DESKTOP-H1JUK44 in /cygdrive/d/Users/Hydra/Documents/dev/projects/betaflight/betaflight-configurator (master)
$ rm -rf cache debug debug node_modules
Hydra on DESKTOP-H1JUK44 in /cygdrive/d/Users/Hydra/Documents/dev/projects/betaflight/betaflight-configurator (master)
$ yarn install && yarn start
yarn install v1.22.21
[1/5] Validating package.json...
[2/5] Resolving packages...
warning Resolution field "libxmljs2@0.32.0" is incompatible with requested version "libxmljs2@^0.29.0"
[3/5] Fetching packages...
[4/5] Linking dependencies...
warning " > vite-plugin-pwa@0.17.5" has unmet peer dependency "workbox-build@^7.0.0".
warning " > vite-plugin-pwa@0.17.5" has unmet peer dependency "workbox-window@^7.0.0".
warning "@storybook/addon-actions > @storybook/addons@6.5.16" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-actions > @storybook/addons@6.5.16" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-actions > @storybook/api@6.5.16" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-actions > @storybook/api@6.5.16" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-actions > @storybook/components@6.5.16" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-actions > @storybook/components@6.5.16" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-actions > @storybook/theming@6.5.16" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-actions > @storybook/theming@6.5.16" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-actions > react-inspector@5.1.1" has unmet peer dependency "react@^16.8.4 || ^17.0.0".
warning "@storybook/addon-links > @storybook/router@6.5.16" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-links > @storybook/router@6.5.16" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-essentials > @storybook/core-common@6.5.16" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-essentials > @storybook/core-common@6.5.16" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-essentials > @storybook/addon-docs > @mdx-js/react@1.6.22" has unmet peer dependency "react@^16.13.1 || ^17.0.0".
warning "@storybook/addon-essentials > @storybook/addon-docs > @storybook/preview-web@6.5.16" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-essentials > @storybook/addon-docs > @storybook/preview-web@6.5.16" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-essentials > @storybook/addon-docs > @storybook/source-loader@6.5.16" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-essentials > @storybook/addon-docs > @storybook/source-loader@6.5.16" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning " > babel-loader@8.3.0" has unmet peer dependency "webpack@>=2".
warning "@storybook/addon-essentials > @storybook/core-common > fork-ts-checker-webpack-plugin@6.5.3" has unmet peer dependency "typescript@>= 2.7".
warning " > @storybook/vue@6.5.16" has unmet peer dependency "css-loader@*".
warning "@storybook/vue > ts-loader@8.4.0" has unmet peer dependency "typescript@*".
warning "@storybook/vue > vue-docgen-loader > jscodeshift@0.13.1" has unmet peer dependency "@babel/preset-env@^7.1.6".
warning " > vue-loader@15.11.1" has unmet peer dependency "css-loader@*".
warning " > vue-loader@15.11.1" has unmet peer dependency "webpack@^3.0.0 || ^4.1.0 || ^5.0.0-0".
[5/5] Building fresh packages...
Done in 21.91s.
yarn run v1.22.21
$ run-script-os
$ set NODE_ENV=development && set NW_PRE_ARGS="--load-extension='./node_modules/nw-vue-devtools-prebuilt/extension' --remote-debugging-port=9222" && gulp debug
Building for platform(s): win64.
[15:36:55] Using gulpfile ~\Documents\dev\projects\betaflight\betaflight-configurator\gulpfile.js
[15:36:55] Starting 'debug'...
[15:36:55] Starting 'clean_dist'...
[15:36:56] Finished 'clean_dist' after 190 ms
[15:36:56] Starting 'process_package_debug'...
[15:36:56] Starting 'write_package_file'...
[15:36:56] Finished 'write_package_file' after 7.95 ms
[15:36:56] Finished 'process_package_debug' after 306 ms
[15:36:56] Starting 'dist_src'...
[15:36:56] Finished 'dist_src' after 393 ms
[15:36:56] Starting 'dist_node_modules_css'...
[15:36:58] Finished 'dist_node_modules_css' after 1.3 s
[15:36:58] Starting 'dist_ol_css'...
[15:36:58] Finished 'dist_ol_css' after 2.38 ms
[15:36:58] Starting 'dist_less'...
[15:36:58] Finished 'dist_less' after 503 ms
[15:36:58] Starting 'dist_locale'...
[15:36:58] Finished 'dist_locale' after 20 ms
[15:36:58] Starting 'dist_libraries'...
[15:36:58] Finished 'dist_libraries' after 5.14 ms
[15:36:58] Starting 'dist_resources'...
[15:36:58] Finished 'dist_resources' after 37 ms
[15:36:58] Starting 'dist_rollup'...
(node-resolve plugin) preferring built-in module 'util' over local alternative at 'D:\Users\Hydra\Documents\dev\projects\betaflight\betaflight-configurator\node_modules\util\util.js', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning
(node-resolve plugin) preferring built-in module 'events' over local alternative at 'D:\Users\Hydra\Documents\dev\projects\betaflight\betaflight-configurator\node_modules\events\events.js', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning
(node-resolve plugin) preferring built-in module 'events' over local alternative at 'D:\Users\Hydra\Documents\dev\projects\betaflight\betaflight-configurator\node_modules\events\events.js', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning
(node-resolve plugin) preferring built-in module 'util' over local alternative at 'D:\Users\Hydra\Documents\dev\projects\betaflight\betaflight-configurator\node_modules\util\util.js', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning
(node-resolve plugin) preferring built-in module 'os' over local alternative at 'D:\Users\Hydra\Documents\dev\projects\betaflight\betaflight-configurator\node_modules\os\index.js', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning
(node-resolve plugin) preferring built-in module 'events' over local alternative at 'D:\Users\Hydra\Documents\dev\projects\betaflight\betaflight-configurator\node_modules\events\events.js', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning
(node-resolve plugin) preferring built-in module 'os' over local alternative at 'D:\Users\Hydra\Documents\dev\projects\betaflight\betaflight-configurator\node_modules\os\index.js', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning
(node-resolve plugin) preferring built-in module 'url' over local alternative at 'D:\Users\Hydra\Documents\dev\projects\betaflight\betaflight-configurator\node_modules\url\url.js', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning
(node-resolve plugin) preferring built-in module 'url' over local alternative at 'D:\Users\Hydra\Documents\dev\projects\betaflight\betaflight-configurator\node_modules\url\url.js', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning
(node-resolve plugin) preferring built-in module 'os' over local alternative at 'D:\Users\Hydra\Documents\dev\projects\betaflight\betaflight-configurator\node_modules\os\index.js', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning
(node-resolve plugin) preferring built-in module 'buffer' over local alternative at 'D:\Users\Hydra\Documents\dev\projects\betaflight\betaflight-configurator\node_modules\buffer\index.js', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning
(node-resolve plugin) preferring built-in module 'buffer' over local alternative at 'D:\Users\Hydra\Documents\dev\projects\betaflight\betaflight-configurator\node_modules\buffer\index.js', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning
(node-resolve plugin) preferring built-in module 'util' over local alternative at 'D:\Users\Hydra\Documents\dev\projects\betaflight\betaflight-configurator\node_modules\util\util.js', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning
(node-resolve plugin) preferring built-in module 'events' over local alternative at 'D:\Users\Hydra\Documents\dev\projects\betaflight\betaflight-configurator\node_modules\events\events.js', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning
(node-resolve plugin) preferring built-in module 'os' over local alternative at 'D:\Users\Hydra\Documents\dev\projects\betaflight\betaflight-configurator\node_modules\os\index.js', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning
(node-resolve plugin) preferring built-in module 'buffer' over local alternative at 'D:\Users\Hydra\Documents\dev\projects\betaflight\betaflight-configurator\node_modules\buffer\index.js', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning
Circular dependency: node_modules/semver/classes/comparator.js -> node_modules/semver/classes/range.js -> node_modules/semver/classes/comparator.js
Circular dependency: src/js/msp.js -> src/js/gui.js -> src/js/msp.js
Circular dependency: src/js/serial.js -> src/js/port_handler.js -> src/js/serial.js
Circular dependency: src/js/port_handler.js -> src/js/mdns_discovery.js -> src/js/port_handler.js
Circular dependency: src/js/tabs/osd.js -> src/js/VirtualFC.js -> src/js/tabs/osd.js
Circular dependency: src/js/msp/MSPHelper.js -> src/js/serial_backend.js -> src/js/msp/MSPHelper.js
Circular dependency: node_modules/d3-selection/src/selection/index.js -> node_modules/d3-selection/src/selection/select.js -> node_modules/d3-selection/src/selection/index.js
Circular dependency: node_modules/d3-selection/src/selection/index.js -> node_modules/d3-selection/src/selection/selectAll.js -> node_modules/d3-selection/src/selection/index.js
Circular dependency: node_modules/d3-selection/src/selection/index.js -> node_modules/d3-selection/src/selection/filter.js -> node_modules/d3-selection/src/selection/index.js
Circular dependency: node_modules/d3-selection/src/selection/index.js -> node_modules/d3-selection/src/selection/data.js -> node_modules/d3-selection/src/selection/index.js
Circular dependency: node_modules/d3-selection/src/selection/index.js -> node_modules/d3-selection/src/selection/data.js -> node_modules/d3-selection/src/selection/enter.js -> node_modules/d3-selection/src/selection/index.js
Circular dependency: node_modules/d3-selection/src/selection/index.js -> node_modules/d3-selection/src/selection/exit.js -> node_modules/d3-selection/src/selection/index.js
Circular dependency: node_modules/d3-selection/src/selection/index.js -> node_modules/d3-selection/src/selection/merge.js -> node_modules/d3-selection/src/selection/index.js
Circular dependency: node_modules/d3-selection/src/selection/index.js -> node_modules/d3-selection/src/selection/sort.js -> node_modules/d3-selection/src/selection/index.js
Circular dependency: node_modules/d3-interpolate/src/value.js -> node_modules/d3-interpolate/src/array.js -> node_modules/d3-interpolate/src/value.js
Circular dependency: node_modules/d3-interpolate/src/value.js -> node_modules/d3-interpolate/src/object.js -> node_modules/d3-interpolate/src/value.js
Circular dependency: node_modules/d3-transition/src/transition/index.js -> node_modules/d3-transition/src/transition/filter.js -> node_modules/d3-transition/src/transition/index.js
Circular dependency: node_modules/d3-transition/src/transition/index.js -> node_modules/d3-transition/src/transition/merge.js -> node_modules/d3-transition/src/transition/index.js
Circular dependency: node_modules/d3-transition/src/transition/index.js -> node_modules/d3-transition/src/transition/select.js -> node_modules/d3-transition/src/transition/index.js
Circular dependency: node_modules/d3-transition/src/transition/index.js -> node_modules/d3-transition/src/transition/selectAll.js -> node_modules/d3-transition/src/transition/index.js
Circular dependency: node_modules/d3-transition/src/transition/index.js -> node_modules/d3-transition/src/transition/transition.js -> node_modules/d3-transition/src/transition/index.js
node_modules/jbox/dist/jBox.all.min.js (1:46175) Use of eval in "node_modules/jbox/dist/jBox.all.min.js" is strongly discouraged as it poses security risks and may cause issues with minification.
Generated an empty chunk: "@petamoriken".
Generated an empty chunk: "d3-chord".
Generated an empty chunk: "d3-contour".
Generated an empty chunk: "d3-delaunay".
Generated an empty chunk: "d3-drag".
Generated an empty chunk: "d3-dsv".
Generated an empty chunk: "d3-fetch".
Generated an empty chunk: "d3-force".
Generated an empty chunk: "d3-geo".
Generated an empty chunk: "d3-hierarchy".
Generated an empty chunk: "d3-polygon".
Generated an empty chunk: "d3-quadtree".
Generated an empty chunk: "d3-random".
Generated an empty chunk: "d3-scale-chromatic".
Generated an empty chunk: "d3-time".
Generated an empty chunk: "d3-time-format".
Generated an empty chunk: "delaunator".
Generated an empty chunk: "earcut".
Generated an empty chunk: "internmap".
Generated an empty chunk: "lerc".
Generated an empty chunk: "quick-lru".
Generated an empty chunk: "robust-predicates".
Generated an empty chunk: "xml-utils".
Generated an empty chunk: "zstddec".
[15:37:10] Finished 'dist_rollup' after 11 s
[15:37:10] Starting 'cordova_dist_none'...
[15:37:10] Finished 'cordova_dist_none' after 171 μs
[15:37:10] Starting 'debug'...
Using v0.72.0 (sdk)
Create cache folder in D:\Users\Hydra\Documents\dev\projects\betaflight\betaflight-configurator\cache\0.72.0-sdk
Downloading: https://dl.nwjs.io/v0.72.0/nwjs-sdk-v0.72.0-win-x64.zip
  downloading [====================] 100% 0.0s

Create release folder in D:\Users\Hydra\Documents\dev\projects\betaflight\betaflight-configurator\debug\betaflight-configurator\win64
Update win64 executable icon
[15:37:41] Finished 'debug' after 31 s
[15:37:41] Starting 'post_build_none'...
[15:37:41] Finished 'post_build_none' after 166 μs
[15:37:41] Starting 'start_debug'...
Starting debug app (debug\betaflight-configurator\win64\betaflight-configurator.exe)...
[15:37:41] Finished 'start_debug' after 9.06 ms
[15:37:41] Finished 'debug' after 46 s
haslinghuis commented 2 weeks ago

@hydra switched version - but still working

image

hydra commented 2 weeks ago

It seems to be somehow related to the firmware, as I had an older FC which I hadn't updated to the latest firmware which only showed one telemetry slider. I then updated it to master, after which I got the same double telemetry slider issue as in the OP.

I performed the above step using an installation of official build of BF and an official build of the BF configurator (from betaflight-configurator_10.10.0_win64-installer.exe) to rule out any build/development artifacts.

# version
# Betaflight / STM32H730 (SP7R) 4.5.0 Apr 29 2024 / 19:28:49 (c155f5830) MSP API: 1.46
# config rev: 2ceeadc
# board: manufacturer_id: SPRO, board_name: SPRACINGH7RF

# status
MCU H730 Clock=520MHz, Vref=3.27V, Core temp=51degC
Stack size: 2048, Stack address: 0x20020000
Configuration: CONFIGURED, size: 4297, max available: 65536
Devices detected: SPI:1, I2C:1
Gyros detected: gyro 1 locked
GYRO=ICM42605, ACC=ICM42605, BARO=BMP388
OSD: MSP (30 x 13)
BUILD KEY: f16e3973633437b41470b27546c19bf3 (4.5.0)
System Uptime: 35 seconds, Current Time: 2024-04-29T19:30:54.172+00:00
CPU:33%, cycle time: 122, GYRO rate: 8196, RX rate: 15, System rate: 9
Voltage: 299 * 0.01V (0S battery - NOT PRESENT)
I2C Errors: 9
SD card: None inserted
GPS: NOT ENABLED
Arming disable flags: RXLOSS CLI MSP

image

image

image