Use the "show manual" preference in the porthandler to show or hide the option

betaflight / betaflight-configurator

Cross platform configuration tool for the Betaflight firmware

GNU General Public License v3.0

2.39k stars 859 forks source link

Closed McGiverGim closed 1 week ago

McGiverGim commented 2 weeks ago

Right now the manual port is always shown. This PR does some things:

Makes the ports combo respect the show manual or not option
Adds a default "Select your device" disabled option to the list of ports, and is the default one when there is no other ports in the list.
With each change, first, tries to select a "real" one port, if not exists the "virtual" and then the "manual". As last option it defaults to "Select your device".

The port handler needs a bigger refactor, this are only the first steps.

netlify[bot] commented 2 weeks ago

Name	Link
Latest commit	5e05e48c909f8de3f2b4a3a3a003524a8bf067c8
Latest deploy log	https://app.netlify.com/sites/origin-betaflight-app/deploys/664f592a4fdf7000080666a3
Deploy Preview	https://deploy-preview-3968.dev.app.betaflight.com
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

chmelevskij commented 2 weeks ago

This breaks current config and virtual mode sync with the config screen. Only visible in initial load when settings are still not set.

McGiverGim commented 2 weeks ago

I will check it again when I rebase the code of the lint PR. Thanks for testing!

McGiverGim commented 1 week ago

Rebased and ready to merge.

McGiverGim commented 1 week ago

Rebased against master.

sonarcloud[bot] commented 1 week ago

Failed conditions
6.9% Duplication on New Code (required ≤ 3%)