Switching from motors tab and back resets the motor status

betaflight / betaflight-configurator

Cross platform configuration tool for the Betaflight firmware

GNU General Public License v3.0

2.57k stars 911 forks source link

Switching from motors tab and back resets the motor status #4160

Closed dmak closed 1 month ago

dmak commented 2 months ago

To Reproduce

Go to Motors tab. Tick "I understand the risks" and start motors using "Master" slider.
Switch to Power & Battery tab. In my case I needed to start motors to calibrate the current for medium throttle.
Switch back to Motors tab.

Result

There is motors hiccup. Probably due to tab initialization.
"I understand the risks" is off, master slider is at zero (motors are still rotating).

Expected behavior

There is no motors hiccup.
"I understand the risks" is on, master slider (or individual motors) positions are remembered.

Configurator version

v10.10.0

haslinghuis commented 2 months ago

Define hiccup in relation to positions are remembered. Following is before and after saving settings on power tab.

dmak commented 2 months ago

I have probably messed up with initial description. Try these steps:

Switch on motors on "Motors" tab.
Go to "Power & Battery" tab. Make tiny change e.g. to voltage and press "Save" (probably will work on other tab as well). Result: FC beeps and motors stop.
Switch to "Motors" tab. "I understand the risks" is on, master slider is not zero (Betaflight thinks motors are rotating). Expected: master slider is at zero.

nerdCopter commented 2 months ago

i believe the motors tab is designed not to reset the motors (sliders) so that a pilot could use other tabs for viewing. especially useful is the sensors tab. however, the action of saving has corrupted the environment.

i wonder if resetting some global motor variable when MSP is saved would be a solution.

haslinghuis commented 1 month ago

@dmak pls check #4188

dmak commented 1 month ago

@dmak pls check #4188

So far looks good. Have to tried/checked switching between tabs when motors are on? Does it work smoothly?

haslinghuis commented 1 month ago

That part has not been changed.