Fix: stop motors on save while testing

betaflight / betaflight-configurator

Cross platform configuration tool for the Betaflight firmware

GNU General Public License v3.0

2.57k stars 910 forks source link

Fix: stop motors on save while testing #4188

Closed haslinghuis closed 1 month ago

haslinghuis commented 1 month ago

fixes #4160

netlify[bot] commented 1 month ago

Deploy Preview for origin-betaflight-app ready!

Name	Link
Latest commit	19159b143014b8fcfe3704b577019d675c87caa8
Latest deploy log	https://app.netlify.com/sites/origin-betaflight-app/deploys/66fc92f6d49d8d0008257483
Deploy Preview	https://deploy-preview-4188.dev.app.betaflight.com
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

McGiverGim commented 1 month ago

A question...

Maybe the fix is the other way? I can't see a capture, or a detailed description, so I'm not too sure what fixes this, but your description is to fix telemetry warning, but you are moving the warning out of the temeletry class, afecting thus all the motor_testing warnings. Is that intended? If not, maybe the fix is to "put" the warning class inside a telemetry class?

haslinghuis commented 1 month ago

This is weird. @ctzsnooze had this issue. Was going to address @McGiverGim's concern, but now it started working in master again.