betaflight / betaflight-configurator

Cross platform configuration tool for the Betaflight firmware
GNU General Public License v3.0
2.57k stars 911 forks source link

Deprecate minthrottle to use motor_idle #4196

Closed haslinghuis closed 1 month ago

haslinghuis commented 1 month ago
netlify[bot] commented 1 month ago

Deploy Preview for origin-betaflight-app ready!

Name Link
Latest commit ea5dd65b6e5cf9ca6f65babd70453ff40d14a245
Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/6705529607f72700081bfce4
Deploy Preview https://deploy-preview-4196.dev.app.betaflight.com
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nerdCopter commented 1 month ago

when MULTISHOT, PWM, PROSHOT, i don't see minThrottle and do see maxThrottle, minCommand image

haslinghuis commented 1 month ago

Correct minthrottle is no longer used in firmware (when merged).

nerdCopter commented 1 month ago

and successfully backwards compatible for <=4.5 image

ctzsnooze commented 1 month ago

@haslinghuis thanks for this work - I can confirm @nerdCopter's test results for 4.6, where selecting an analog protocol still shows minThrottle, where it should show the same MotorIdle value as we see with DShot:

Screen Shot 2024-10-05 at 11 02 57 am
haslinghuis commented 1 month ago

On 4.6 we have:

image

On 4.5 we have

image

ctzsnooze commented 1 month ago

Approving - motor idle renders as it should in 4.6! Thank you!

Let's see how it works if the message text us sensitive to the dynamic idle state, that should halve the message length, making it small enough.

Maybe these tooltips can auto-size themselves a bit wider for computer screens?

haslinghuis commented 1 month ago
ctzsnooze commented 1 month ago

Wide tip looks good! Maybe update the text with the shorter version that I provided? Should be good to go once the firmware is merged.

haslinghuis commented 1 month ago

image

ctzsnooze commented 1 month ago

@haslinghuis - while we are thinking about this, my personal view is that the user doesn't need two decimal points of accuracy in the idle percentage, even though we provide it with the 16 bit value in the CLI.
Maybe we can in Configurator only provide 1 decimal point of adjustment? ie 5.1, 5.2 etc steps, not 5.10, 5.11, 5.12, when using the up and down arrows?

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud