betaflight / betaflight-tx-lua-scripts

Collection of scripts to configure Betaflight from your TX (currently only supported in OpenTx)
GNU General Public License v3.0
590 stars 142 forks source link

Add scale to ground speed for >= API 1.45 #466

Closed haslinghuis closed 1 year ago

haslinghuis commented 1 year ago

Fixes: #465

klutvott123 commented 1 year ago

Did this change? Or was it always like that?

haslinghuis commented 1 year ago

Yes scale seem to be wrong before (in any case looking at https://github.com/betaflight/betaflight/pull/11834/files Seems to be changed in 1.45 (at least the scale).

:confused: Might need to update the label:

{ "RETURN SPEED CM/S", OME_UINT16 | REBOOT_REQUIRED, NULL, &(OSD_UINT16_t){ &gpsRescueConfig_rescueGroundspeed, 0, 3000, 1 } },

klutvott123 commented 1 year ago

Yes scale seem to be wrong before (in any case looking at https://github.com/betaflight/betaflight/pull/11834/files Seems to be changed in 1.45 (at least the scale).

😕 Might need to update the label:

{ "RETURN SPEED CM/S", OME_UINT16 | REBOOT_REQUIRED, NULL, &(OSD_UINT16_t){ &gpsRescueConfig_rescueGroundspeed, 0, 3000, 1 } },

I think the label should be consistent with the configurator label, and the number itself should be shown as in the configurator.

This is the kind of bugs we get when labels aren't used. "needs coordination with betaflight configurator" lets us look at the milestone and pick up all the changes that have been made to user changeable parameters. Sure it might be that the person implementing the changes in firmware are doing the configurator PR as well, but still labels should be used.

haslinghuis commented 1 year ago

Configurator UI seems not have been updated ground speed. Last time it was updated: https://github.com/betaflight/betaflight-configurator/pull/1946

haslinghuis commented 1 year ago

@ctzsnooze - can you help us out here?