betaflight / betaflight

Open Source Flight Controller Firmware

GNU General Public License v3.0

8.01k stars 2.86k forks source link

bug - flash - SPRASINGH7NANO can't handle 100MHz #13571

Closed ledvinap closed 3 weeks ago

ledvinap commented 3 weeks ago

https://github.com/betaflight/betaflight/pull/13555 changed SPI speed to 100MHz. SPRASINGH7NANO (using QUADSPI, so not directly related to #13555) won't boot with this setting.

github-actions[bot] commented 3 weeks ago

Do you want to test this code? You can flash it directly from Betaflight Configurator:

Simply put #13571 (this pull request number) in the Select commit field of the Configurator firmware flasher tab (you need to Enable expert mode, Show release candidates and Development).

WARNING: It may be unstable. Use only for testing!

ledvinap commented 3 weeks ago

@betaflight/administrators Please approve ASAP, current master is bricking H7NANO ...

SteveCEvans commented 3 weeks ago

We still need 100MHz setting for SPI or we can't log at 8kHz. I suggest wrapping this in #ifndef USE_QUADSPI.

ledvinap commented 3 weeks ago

We still need 100MHz setting for SPI or we can't log at 8kHz. I suggest wrapping this in #ifndef USE_QUADSPI.

I'd keep speed used before https://github.com/betaflight/betaflight/pull/13555 and fine-tune it in https://github.com/betaflight/betaflight/pull/13562. It is possible that speed limit is not QSPI related.

hydra commented 3 weeks ago

Please revert to the old SPI speed since #13555 was accidentally merged before the work and testing was completed, especially as we're in RC phase, and #13555 feels like a new feature to me and should probably have been in 4.6.

SteveCEvans commented 3 weeks ago

Please revert to the old SPI speed since #13555 was accidentally merged before the work and testing was completed, especially as we're in RC phase, and #13555 feels like a new feature to me and should probably have been in 4.6.

13555 enables black box logging on 30 FC types and doesn't affect FCs which don't use this type on FLASH.

haslinghuis commented 3 weeks ago

@SteveCEvans

lets merge this and continue in #13562

SteveCEvans commented 3 weeks ago

We still need 100MHz setting for SPI or we can't log at 8kHz. I suggest wrapping this in #ifndef USE_QUADSPI.

I'd keep speed used before #13555 and fine-tune it in #13562. It is possible that speed limit is not QSPI related.

Processor won't run that fast, but the datasheet says it's good for 104MHz.

haslinghuis commented 3 weeks ago

Fixed in #13562