Unnecessary features automatically enabled by default.

hydra commented 2 weeks ago

Describe the bug

After issuing 'defaults' in the cli, and then 'diff' I get this:

feature SERVO_TILT
feature RANGEFINDER
feature DISPLAY
feature CHANNEL_FORWARDING
feature TRANSPONDER

The target has various, 'USE_...' defined, e.g. 'USE_SERVOS', but that shouldn't mean that features using the code enabled by the define should be used.

To Reproduce

1) Build and flash any H7 target from source, tested on H7EXTREME and H7RF, likely happens on other targets too.
2) issue 'defaults' in the cli. 3) wait for reboot. 4) go back to the cli and check the 'diff' output.

Expected behavior

Only the features actually wanted are enabled. i.e. none of the above should be enabled by default.

Support ID

N/A

Flight controller

Any H7

Other components

No response

How are the different components wired up (including port information)

No response

Add any other context about the problem that you think might be relevant here

See validateAndFixConfig.

e.g.

#ifdef USE_RANGEFINDER
    featureEnableImmediate(FEATURE_RANGEFINDER);
#endif
#ifdef USE_SERVOS
    featureEnableImmediate(FEATURE_CHANNEL_FORWARDING);
    featureEnableImmediate(FEATURE_SERVO_TILT);
#endif

hydra commented 2 weeks ago

This is tested on 4.5-maintenance from yesterday's release of 4.5.0, commit: c155f5830d0ffdee1c34071dd21f174ffc374c81

ledvinap commented 2 weeks ago

@hydra: someone spent considerable effort to enable these features (config and feature handling is total mess).

Maybe we can use different values of USE_ define?

#define FEATURE_DEFAULT_OFF 1
#define FEATURE_DEFAULT_ON 2
#define FEATURE_FORCE_ON 3

#define USE_SERVO FEATURE_DEFAULT_OFF

with some improvement/rewording

hydra commented 4 days ago

@ledvinap Not sure what the solution is, but there's some good discussion in https://github.com/betaflight/betaflight/pull/13608

betaflight / betaflight