Do not enable features by default

betaflight / betaflight

Open Source Flight Controller Firmware

GNU General Public License v3.0

8k stars 2.86k forks source link

Do not enable features by default #13608

Open haslinghuis opened 2 weeks ago

haslinghuis commented 2 weeks ago

Fixes #13590
See also #13494 which should be merged first

github-actions[bot] commented 2 weeks ago

Do you want to test this code? You can flash it directly from Betaflight Configurator:

Simply put #13608 (this pull request number) in the Select commit field of the Configurator firmware flasher tab (you need to Enable expert mode, Show release candidates and Development).

WARNING: It may be unstable. Use only for testing!

ledvinap commented 2 weeks ago

@haslinghuis problem is that you want osd only on targets with integrated osd. the same with other features...

haslinghuis commented 2 weeks ago

@ledvinap OSD feature is also used when using MSP instead of MAX7456

hydra commented 2 weeks ago

@haslinghuis problem is that you want osd only on targets with integrated osd. the same with other features...

I think the situations where you want it enabled by default are as follows: 1) FC has OSD on-board. (MAX7456/AT7456, FrSkyOSD, SPRacingPixelOSD, etc) 2) FC has HD/DJI OSD connector or is always paired with an MSP DisplayPort device (daughter board, stack, etc) and one serial port is configured by default to use MSP DisplayPort.

haslinghuis commented 2 weeks ago

Currently

OSD_SD and OSD_HD is a default build option. User should choose which one or neither to use.
Including OSD_HD defaults to MSP displayport as switching between analog or hd video system does not work in respect to positioning the elements.