search

betaflight / blackbox-log-viewer

Interactive log viewer for flight logs recorded with blackbox
GNU General Public License v3.0
449 stars 147 forks source link

RC Rates do not update after rateprofile switch #236

Open ianrmurphy opened 6 years ago

ianrmurphy commented 6 years ago

When switching rate values using rateprofile mapped to an Aux switch, the RC Rates graphs do not update to show the correct values for the new rates. RC Rates appear to be calculated internal to blackbox-log-viewer (flightlog.js/calculateSetpointRate()) from the header data, which is not refreshed upon the rateprofile change. Only an event marker is inserted. This is likely known behaviour but I could not find any reference to it in previous issues or other documentation.

McGiverGim commented 6 years ago

Yes. It is calculated at the beginning ignoring rate changes. Attach a log and I will try to check it when I have time.

ianrmurphy commented 6 years ago

Will do, I need to take a log with stock 3.4.0 firmware as I'm currently flying versions related to https://github.com/betaflight/betaflight/pull/6402 that won't show correct behaviour (or reproduce the issue accurately) unless viewed with https://github.com/betaflight/blackbox-log-viewer/pull/237 .

stale[bot] commented 6 years ago

This issue / pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

stale[bot] commented 6 years ago

Automatically closing as inactive.

ctzsnooze commented 6 years ago

Here's an example, rates were changed twice, we can see the RC Rate calculation not changing after the rate profile change in the log. YawTesting.BBL.zip

ctzsnooze commented 6 years ago

rate profile change that's the first rate profile change, where set rate was changed from 720 to 920 - looks like I suddenly was overshooting the target ! :-)

stale[bot] commented 6 years ago

This issue / pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

stale[bot] commented 6 years ago

Automatically closing as inactive.

McGiverGim commented 6 years ago

I reopen this. I had no time to look into it but perhaps...