betaflight / blackbox-tools

Tools for working with blackbox flight logs
GNU General Public License v3.0
61 stars 36 forks source link

blackbox log header structure contradicts blackbox_decode parser.c logic #33

Closed metametaclass closed 4 years ago

metametaclass commented 4 years ago

Describe the bug "features" field is described as "last field in the header":

if (strstr(fieldName,"features")) { // This is the last field in the header.
        *parserState = PARSER_STATE_TRANSITION;
}

but actual logs contains more fields after this field:

H features:939787272
H rc_smoothing_type:1
H rc_smoothing_debug_axis:0
H rc_smoothing_cutoffs:0, 0
H rc_smoothing_auto_factor:10
H rc_smoothing_filter_type:1, 2
H rc_smoothing_active_cutoffs:67, 67
H rc_smoothing_rx_average:6681
I.....

To Reproduce Open any blackbox log.

Expected behavior Additional fields should be written before "features"

Flight controller configuration Doesn`t matter

Setup / Versions

Additional context

etracer65 commented 4 years ago

Moved this issue to the correct repository. The blackbox tools haven't had any active development in a long time so it's not surprising that they're not in sync.

stale[bot] commented 4 years ago

This issue / pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

stale[bot] commented 4 years ago

Automatically closing as inactive.