search

betaflight / blackbox-tools

Tools for working with blackbox flight logs
GNU General Public License v3.0
61 stars 36 forks source link

Update blackbox_decode.c #41

Closed xsnoopy closed 1 year ago

xsnoopy commented 3 years ago

Added Units for simulate IMU

Issue https://github.com/betaflight/blackbox-tools/issues/39

rickmanship commented 3 years ago

Changing the heading for no reason other than to change it means that any other tools that parse the files might break since they would be expecting different headers. I know some of the PID analysis tools consume these files so this change is likely to break them. The headings have been like this for a long time and it's never been a problem so I don't see why it should be changed.

xsnoopy commented 3 years ago

Unlikely that this happens IMU shouldn´t be used for PID analysis.

dellch commented 3 years ago

What about adding a flag, --include-imu-units

Also, shouldn't this be added to Units.h arrays to be consistent with the rest of the code?

mikeller commented 3 years ago

@xsnoopy: Can you please rebase to resolve the conflicts?

xsnoopy commented 3 years ago

I think it's taking care of by this pull request https://github.com/betaflight/blackbox-tools/pull/43