Main parser loop cleaned up.

betaflight / blackbox-tools

Tools for working with blackbox flight logs

GNU General Public License v3.0

61 stars 36 forks source link

Main parser loop cleaned up. #8

Closed JamesCordell closed 6 years ago

JamesCordell commented 6 years ago

I have tested with log files before and after my changes. The logs have not changed. It was necessary to make these changes to simplify the loop so I could add a serial buffer so Frames can be decoded piecewise. More and different log files will help find bugs.

mikeller commented 6 years ago

Wow, this IS a lot of change. I think it is better to split this up into multiple pull requests for individual improvements, as it is just about impossible to review this as it is.

Also, please make sure that your code is cleaned up before you open a pull request, with respect to:

extra whitespace;
commented out code;
leftover test files;
if you've got a large number of commits before you even open a pull request, please squash them first.

JamesCordell commented 6 years ago

I have done as you asked. Is this better? I still have to add serial that will come later.