Closed limonspb closed 10 months ago
This PR is the first PR in the sequence of transferring tune/filter presets for 4.5.
My dream about full transfer defaults to PG groups can't become true yet. The main reason that
PG_GYRO_CONFIG
includes some stuff that's hardware/user related. And thatPG_PID_PROFILE
contains d-term filters.So for 4.5 filters defaults can only use:
defaults group_id 554 nosave # PG_DYN_NOTCH_CONFIG
defaults group_id 544 nosave # PG_RPM_FILTER_CONFIG
which I did here.the rest of the parameters should be listed explicitly.
I listed them in the order they appear in CLI, that's easier to maintain.
The next PRs will be:
- 4.5 tune defaults
- Remove 4.5 firmware from previous tunes/filters presets
- Copy filter/tune presets over to 4.5 folder and tag them as 4.5
what are PG groups?
We recently discussed with UAV Tech about how to approach 4.5 presets. You wanted to add 4.5 firmware naming to the 4.4 preset to avoid repetition. Does this mean that we are changing tack now to discrete 4.5 presets?
This PR is the first PR in the sequence of transferring tune/filter presets for 4.5. My dream about full transfer defaults to PG groups can't become true yet. The main reason that
PG_GYRO_CONFIG
includes some stuff that's hardware/user related. And thatPG_PID_PROFILE
contains d-term filters. So for 4.5 filters defaults can only use:defaults group_id 554 nosave # PG_DYN_NOTCH_CONFIG
defaults group_id 544 nosave # PG_RPM_FILTER_CONFIG
which I did here. the rest of the parameters should be listed explicitly. I listed them in the order they appear in CLI, that's easier to maintain. The next PRs will be:
- 4.5 tune defaults
- Remove 4.5 firmware from previous tunes/filters presets
- Copy filter/tune presets over to 4.5 folder and tag them as 4.5
what are PG groups?
We recently discussed with UAV Tech about how to approach 4.5 presets. You wanted to add 4.5 firmware naming to the 4.4 preset to avoid repetition. Does this mean that we are changing tack now to discrete 4.5 presets?
yes, i will take care of all that, authors don't need to do anything, except if they need some values to be adjusted. I will prepare new defaults, and will copy over presets from 4.4 to 4.5.
PG groups are the groups of parameters that can be reset in one command. For example
defaults group_id 554 nosave
resets dynamic notch config.
This PR is the first PR in the sequence of transferring tune/filter presets for 4.5.
My dream about full transfer defaults to PG groups can't become true yet. The main reason that
PG_GYRO_CONFIG
includes some stuff that's hardware/user related. And thatPG_PID_PROFILE
contains d-term filters.So for 4.5 filters defaults can only use:
defaults group_id 554 nosave # PG_DYN_NOTCH_CONFIG
defaults group_id 544 nosave # PG_RPM_FILTER_CONFIG
which I did here.the rest of the parameters should be listed explicitly.
I listed them in the order they appear in CLI, that's easier to maintain.
The next PRs will be: