Closed VolkerGoeschl closed 5 months ago
Dear Ivan!
First things first: I'm not a Sir. Although I'm 45 I would preferere a slightly more casual adressing ("shit pilot" will do fine also I'm not sure I earned it).
Second: Thank you very much for having a look - It's very much appreciated!
Now for the actual problems in my "code":
#$ STATUS: EXPERIMENTAL
nope We have flown well over 2k packs on those settings on dozends of rigs so I'm pretty confident they will work
#$ PARSER: MARKED
I'll fix it
simplified_tuning apply
thanks- I'll fix it is there a similar command for filters as well?
Its recommended to use 4 spaces as a tab, not 2
done some python? ;-)
#$ TITLE: AOS Rates
upsi
profile selection and small_angle I'll fix it!
set vbat_sag_compensation = 80
Is this negotiable? Since the best pack for keeping the weight of those rigs under 250g is a HV this is definitly needed. Otherwise you would get Dterm-trilling for the first 30-60 seconds or have an undertuned rig for the second half of each pack.
Dear Ivan! First things first: I'm not a Sir. Although I'm 45 I would preferere a slightly more casual adressing ("shit pilot" will do fine also I'm not sure I earned it). Second: Thank you very much for having a look - It's very much appreciated! Now for the actual problems in my "code":
#$ STATUS: EXPERIMENTAL
nope We have flown well over 2k packs on those settings on dozends of rigs so I'm pretty confident they will work#$ PARSER: MARKED
I'll fix itsimplified_tuning apply
thanks- I'll fix it is there a similar command for filters as well?Its recommended to use 4 spaces as a tab, not 2
done some python? ;-)
#$ TITLE: AOS Rates
upsi profile selection and small_angle I'll fix it!set vbat_sag_compensation = 80
Is this negotiable? Since the best pack for keeping the weight of those rigs under 250g is a HV this is definitly needed. Otherwise you would get Dterm-trilling for the first 30-60 seconds or have an undertuned rig for the second half of each pack.
Hehe :)
About #$ STATUS: EXPERIMENTAL
- i understand that lots of people might be running your settings. But making a preset from the settings can cause extra errors. So i have no doubt in your settings, but there is a danger from making a preset, syntax, forgetting to copy-paste something etc. That's why new preset files should be EXPERIMENTAL at first for some time. It's like a release-candidate stage, since presets are going online right away after approval.
simplified_tuning apply
does the magic for all active sliders, PIDs and filters.
set vbat_sag_compensation = 80
- fair point, it also affects the tune...
Thanks for clarifying the experimental status -> I totally agree (and changed it)
nice, now plz check your presets in configurator. Make any fixes if needed in a new PR :)
Thank you so much for guiding me through this! And to quote Botgrinder: Next time will be better ;-)
High everyone! This PR is my first one to this repo ->I hope everything is in order. Otherwise lent me know so future PRs will be less of a hazzle.