search

betagouv / betaGouvBot

Automated assistant for beta.gouv.fr administrative tasks on slack.
https://beta.gouv.fr
MIT License
4 stars 10 forks source link

Revert "Refactoring rules and mail formatting" #85

Closed bonjourmauko closed 7 years ago

bonjourmauko commented 7 years ago

Reverts sgmap/betaGouvBot#80

Morendil commented 7 years ago

Another option is to merge #83 which fixed it, but you can take some time to review if you want. Mailer being broken shouldn't be a problem until june 15th :)

bonjourmauko commented 7 years ago

@Morendil Take a look at #86

bonjourmauko commented 7 years ago

@Morendil I propose you to merge #85 and #86, #83 goes in the same direction.

Morendil commented 7 years ago

Please help me out if I'm confused: intuitively if we are going to apply "Revert X" and then "X" where X is a previously merged PR, we might as well not merge either and just merge #83? The corrections applied for "entanglement" are not needed after #83.

bonjourmauko commented 7 years ago

@Morendil Closed #85, check for #86 as it's a refactoring by itself.