component: Button

[adipasquale]

cf #62

• I used the label param name for the actual button content as does the DSFR guide because it’s also possible to set a tag attribute title on the <button> tag.
• I used a single :level param that takes :primary, :secondary or :tertiary. we could also use primary: true, secondary: true... I don’t really have a preference
• I used an icon param that takes the class name without the fr-icon- prefix, i.e. checkbox-line + a second param icon_position : :left or :right. This is quite different from what you had done with the dsfr_link_to helper but I believe it’s a better direction. I feel it should be easy to add an icon without thinking about its position, so icon: "checkbox-line" should work on its own. I don’t have a strong opinion though.

icons are broken in the guide but i think it’s okay, I’ll double check

[freesteph]

I was hoping we could implement this as dsfr_button_to, the GOV.UK way which we've followed for links. Did you look into it?

[adipasquale]

nope @freesteph I have not looked into it but I don’t think it’s incompatible, do you ? we can always implement the dsfr_button_to helper later, no ? even if it means refactoring this button component I don’t think we can get away without a Button component though, the same way we got away without a Link component. Buttons are used in other contexts than the button_to rails helper allows for

[adipasquale]

let me know if that works with you @freesteph because the modal one is dependent on this one and I started using dsfr-view-components with the modal branch on collectif objets :)

[freesteph]

Okay cool. I'll look into the helper form at some point.