search

betagouv / pad.numerique.gouv.fr

Pad numérique de l'état
https://pad.numerique.gouv.fr/
GNU Affero General Public License v3.0
6 stars 1 forks source link

🐛 (backend) force AgentConnect `profileId` to Lowercase #55

Closed lebaudantoine closed 3 months ago

lebaudantoine commented 4 months ago

The profileId provided by identity providers is not always in lowercase. During the migration from MCP to Agent Connect, a few users lost their documents because their identity provider returned a capitalized email. This issue primarily affected users of development durable connected with Cerbere.

Although it should be the responsibility of the identity provider to manage email addresses, reconciling based on email case sensitivity is poor practice. This commit enforces handling profileId as case-insensitive to mitigate this issue, even if it diverges from the specification.

Note: This change might introduce future regressions. However, @sampaccoud and @rdubigny have approved this approach.

lebaudantoine commented 4 months ago

Deployed and tested in staging!