search

betagouv / preuve-covoiturage

Registre de preuve de covoiturage
https://app.covoiturage.beta.gouv.fr
Apache License 2.0
33 stars 12 forks source link

Campagne: Lannion-Trégor 2024 #2481

Closed jonathanfallon closed 4 months ago

jonathanfallon commented 4 months ago

policy_id : 1056

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

Walkthrough

The recent changes focus on enhancing carpooling policies in the Lannion-Trégor region for 2024. These updates include refining policy handlers, adding tests for policy functionalities, and adjusting UI components for better user experience.

Changes

File Path Change Summary
.../policies/LannionTregor2024.html.ts, .../LannionTregor2024.ts Introduced a new policy handler with detailed rules for the Lannion-Trégor 2024 carpooling campaign.
.../policies/LannionTregor2024.spec.ts Added test cases to validate the behavior of the new policy handler in various carpooling scenarios.
.../campaign-ui/.../campaign-main-metrics.component.ts Updated the end date calculation logic to display the correct campaign duration to users.

🐰✨ In Lannion-Trégor, policies take flight, Tests ensure they're shining bright. UI tweaks for a better view, Carpooling rules, fresh and new. Let's celebrate this coding brew! 🚗🌟

Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between f677fcc22d1883175dad31901f3ee870000d8c9e and a77cf717c33f8ee5845c8f28d214ccae2c65b9e0.
Files selected for processing (9) * .vscode/typescript.json.code-snippets (1 hunks) * api/src/pdc/services/policy/engine/helpers/onDistanceRange.spec.ts (1 hunks) * api/src/pdc/services/policy/engine/helpers/onDistanceRange.ts (2 hunks) * api/src/pdc/services/policy/engine/helpers/per.ts (1 hunks) * api/src/pdc/services/policy/engine/policies/LannionTregor2024.html.ts (1 hunks) * api/src/pdc/services/policy/engine/policies/LannionTregor2024.spec.ts (1 hunks) * api/src/pdc/services/policy/engine/policies/LannionTregor2024.ts (1 hunks) * api/src/pdc/services/policy/engine/policies/index.ts (2 hunks) * dashboard/src/app/modules/campaign/modules/campaign-ui/components/campaign-main-metrics/campaign-main-metrics.component.ts (1 hunks)
Files skipped from review due to trivial changes (2) * .vscode/typescript.json.code-snippets * api/src/pdc/services/policy/engine/policies/index.ts
Files skipped from review as they are similar to previous changes (4) * api/src/pdc/services/policy/engine/policies/LannionTregor2024.html.ts * api/src/pdc/services/policy/engine/policies/LannionTregor2024.spec.ts * api/src/pdc/services/policy/engine/policies/LannionTregor2024.ts * dashboard/src/app/modules/campaign/modules/campaign-ui/components/campaign-main-metrics/campaign-main-metrics.component.ts
Additional comments not posted (14)
api/src/pdc/services/policy/engine/helpers/per.ts (2)
`19-20`: LGTM! The logic for handling distance calculations with offset and limit is correctly implemented. --- `20-20`: LGTM! The `perSeat` function correctly calculates the amount based on the number of seats, defaulting to 1 if not specified.
api/src/pdc/services/policy/engine/helpers/onDistanceRange.ts (2)
`14-16`: LGTM! The function correctly handles cases where the carpool distance is missing by throwing an `InvalidParamsException`. --- `25-25`: LGTM! The function `onDistanceRangeOrThrow` correctly uses the `onDistanceRange` function to validate the distance and throws an exception if it's out of range.
api/src/pdc/services/policy/engine/helpers/onDistanceRange.spec.ts (10)
`13-13`: LGTM! The test case correctly checks that the function returns false when the distance is under the specified range. --- `17-17`: LGTM! The test case correctly checks that the function returns false when the distance is above the specified range. --- `21-22`: LGTM! The test case correctly checks that the function returns true when the distance is within the specified range. --- `25-26`: LGTM! The test case correctly checks that the function returns true when the distance is exactly on the minimum specified range. --- `29-30`: LGTM! The test case correctly checks that the function returns false when the distance is exactly on the maximum specified range. --- `33-34`: LGTM! The test case correctly checks that the function returns true when no parameters are provided. --- `37-38`: LGTM! The test case correctly checks that the function returns true when the minimum parameter is missing and the distance is within the specified maximum range. --- `41-42`: LGTM! The test case correctly checks that the function returns false when the minimum parameter is missing and the distance is not within the specified maximum range. --- `45-46`: LGTM! The test case correctly checks that the function returns true when the maximum parameter is missing and the distance is within the specified minimum range. --- `49-49`: LGTM! The test case correctly checks that the function returns false when the maximum parameter is missing and the distance is not within the specified minimum range.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.