Closed nmrgt closed 3 months ago
The recent changes streamline the finalization process in the policy management system by removing the handling of locks and deadlocks. This includes eliminating lock-related methods and parameters across various files, simplifying the overall logic and focusing on the core functionality of resyncing incentive sums for policies.
Files | Change Summary |
---|---|
api/src/pdc/services/policy/actions/FinalizeAction.ts |
Removed manual clearing of deadlocks and explicit handling of locks. Updated defaultParams method to exclude clear parameter. |
api/src/pdc/services/policy/commands/FinalizeCommand.ts |
Removed --clear option and clear parameter from command options and ParamsInterface object. |
api/src/pdc/services/policy/interfaces/providers/PolicyRepositoryProviderInterface.ts |
Removed LockInformationInterface and methods getLock , releaseLock , and clearDeadLocks from PolicyRepositoryProviderInterfaceResolver . |
api/src/pdc/services/policy/interfaces/providers/index.ts |
Removed LockInformationInterface from exports. |
api/src/pdc/services/policy/providers/PolicyRepositoryProvider.integration.spec.ts |
Removed test function related to getting a lock in the policy repository provider. |
api/src/pdc/services/policy/providers/PolicyRepositoryProvider.ts |
Removed methods and declarations related to lock functionality, including getLock , releaseLock , clearDeadLocks , and lockTable . |
shared/policy/finalize.contract.ts |
Removed clear property from ParamsInterface type. |
In the code's quiet hum and flow, Locks and deadlocks had to go. Simplified paths, clear and bright, Policies resync in the light. A rabbit's work, neat and tight, Brings to code a new delight.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Tests