coderabbitai[bot]
commented
3 months ago [!WARNING]
Rate limit exceeded
@jonathanfallon has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 32 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between 42c9738ffafaea9b0a08aed0ce6d1149df0753ad and f53ecfc75b4a87e9205b0ebe1a56691136affbea.
Walkthrough
The recent changes introduce a legacy_id column to the carpool version 2 schema, ensuring compatibility with older systems while transitioning to a new identifier system. This update involves modifications across multiple files, including database migrations, interfaces, repositories, and service actions, to incorporate and handle the new legacy_id field seamlessly.
Changes
| Files | Change Summary |
|---|---|
api/src/db/migrations/... |
Added migration scripts to create and drop the legacy_id column in the carpool_v2 schema. |
api/src/pdc/providers/carpool/interfaces/database/carpool.ts |
Added legacy_id field to InsertableCarpool interface. |
api/src/pdc/providers/carpool/mocks/database/carpool.ts |
Added legacy_id field to the insertableCarpool mock object. |
api/src/pdc/providers/carpool/repositories/CarpoolLookupRepository.ts |
Included parsing of legacy_id as an integer in the returned carpool data. |
api/src/pdc/providers/carpool/repositories/CarpoolRepository.integration.spec.ts |
Modified getCarpool function to parse legacy_id as an integer for comparison. |
api/src/pdc/providers/carpool/repositories/CarpoolRepository.ts |
Added legacy_id field to the SQL INSERT query. |
api/src/pdc/providers/seed/Migrator.ts |
Updated seedCarpoolV2 method to include legacy_id and acquisition_id in SQL queries and added debug logging. |
api/src/pdc/services/acquisition/actions/CreateJourneyAction.ts |
Added legacy_id to the object passed to registerRequest method. |
api/src/pdc/services/acquisition/commands/MigrateAcquisitionCommand.ts |
Added legacy_id to the object passed to the register method of carpool. |
api/src/pdc/services/acquisition/interfaces/AcquisitionRepositoryProviderInterface.ts |
Added _id property to AcquisitionCreateResultInterface. |
api/src/pdc/services/acquisition/providers/AcquisitionRepositoryProvider.ts |
Modified SQL query to include _id in RETURNING clause and updated return type. |
api/src/pdc/services/cee/actions/RegisterCeeAction.ts |
Changed journey_id property to use carpoolData.journey_id. |
api/src/pdc/services/cee/interfaces/CeeRepositoryProviderInterface.ts |
Changed type of uuid to JourneyId in ValidJourney interface. |
api/src/pdc/services/cee/providers/CeeRepositoryProvider.ts |
Updated SQL queries to use cc.legacy_id as journey_id instead of cc.uuid. |
shared/cee/common/CeeApplicationInterface.ts |
Changed JourneyId type from string to number. |
Sequence Diagram(s) (Beta)
sequenceDiagram
participant User
participant CreateJourneyAction
participant CarpoolRepository
participant Database
User->>CreateJourneyAction: Create Journey
CreateJourneyAction->>CarpoolRepository: Insert Carpool Data
CarpoolRepository->>Database: INSERT INTO carpools (legacy_id, ...)
Database-->>CarpoolRepository: Return legacy_id
CarpoolRepository-->>CreateJourneyAction: Return Insert Result
CreateJourneyAction-->>User: Journey Created with legacy_idPossibly related issues
- Issue betagouv/preuve-covoiturage#2474: The changes in this PR support the migration to
carpool_v2schema, which aligns with the objectives of addingoperator_journey_idand updating the CEE application process.
Poem
In code we weave a tale anew,
Withlegacy_idour bridge to view,
From old to new, the data flows,
As carpool journeys onward goes.
Debug logs and queries bright,
Guiding us through day and night.
🐇✨ In every byte, a future's light.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
rollback du journey_id des demandes CEE vers l'acquisition_id
legacy_iddans carpool V2Summary by CodeRabbit
New Features
legacy_idcolumn to the carpool database schema for better data management and migration.Bug Fixes
legacy_idfield.Refactor
legacy_idfield.Chores
legacy_idfield.These changes improve data consistency and facilitate smoother migrations within the carpooling system.