Closed jonathanfallon closed 2 months ago
The recent changes provide enhanced testing capabilities and setup adjustments within the PDC API codebase. Key updates include enriching database helper functions, expanding middleware usage, integrating parameter validation improvements, and refining schemas. Additionally, the modifications now support multiple service providers, facilitating more robust and flexible testing configurations.
File Path | Change Summary |
---|---|
api/src/pdc/providers/test/dbMacro.ts |
Added documentation and examples for database helper functions. |
api/src/pdc/providers/test/handlerMacro.ts |
Updated assertHandler callback signature to allow void return type. |
api/src/pdc/providers/test/helpers.ts |
Enhanced KernelContext , makeKernel , and makeKernelBeforeAfter for multi-service setup and test configurations |
...actions/CreateAction.integration.spec.ts |
Added integration tests for CreateActionV2 and CreateActionV3 classes. |
api/src/pdc/services/export/actions/CreateActionV3.ts |
Introduced new middleware functions, updated parameter handling in CreateActionV3 class. |
api/src/pdc/services/export/middlewares/ScopeToGroupMiddleware.integration.spec.ts |
Updated parameter types to use TerritorySelectorsInterface . |
shared/export/create.schema.ts |
Changed string literals from single quotes to double quotes across schema definitions. |
sequenceDiagram
participant TestSuite
participant DbMacro
participant Kernel
participant Services
TestSuite->>DbMacro: makeDbBeforeAfter(cfg)
DbMacro->>DbMacro: Setup/Cleanup Test Database
TestSuite->>Kernel: makeKernel(...serviceProviders)
activate Kernel
Kernel-->>Services: Initialize Services
Services-->>Kernel: Services Ready
deactivate Kernel
Kernel-->>TestSuite: Kernel Ready with Multiple Services
TestSuite-->>TestSuite: Execute Integration Tests
sequenceDiagram
participant Client
participant CreateActionV3
participant Middleware
participant Validator
Client->>CreateActionV3: Call CreateActionV3
CreateActionV3->>Middleware: Process Middlewares
Middleware-->>CreateActionV3: Processed Data
CreateActionV3->>Validator: Validate Dates and Params
Validator-->>CreateActionV3: Validated Params
CreateActionV3-->>Client: Return Success Response
Amidst the code, where tests evolve,
Through middlewares, our tasks resolve.
The kernels caper, swift and bright,
Services dance, a joyous sight.
In lines of change, our strength is spun,
To better tasks, the tests are done.
🎩🐇 CodeRabbit's decree, the work's begun! 🌟
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
:warning: l'API de sortie du helper
before
a été modifiée :service -> services
. La propriété n'était pas utilisée.Summary by CodeRabbit
Documentation
Bug Fixes
assertHandler
to supportvoid
return type.New Features
makeKernelBeforeAfter
for easier integration test setup.CreateActionV3
with new middleware functions and enhanced date handling.CreateActionV2
andCreateActionV3
.Refactor
Style
shared/export/create.schema.ts
.Tests