search

betagouv / preuve-covoiturage

Registre de preuve de covoiturage
https://app.covoiturage.beta.gouv.fr
Apache License 2.0
35 stars 12 forks source link

Fix/operators policy list #2567

Closed P3rceval closed 2 months ago

P3rceval commented 2 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The changes encompass updates to various files, including modifications to a GitHub Actions workflow for security scanning, enhancements to the ListAction class with new logic for operator UUID checks, and the introduction of an allTimeOperators property in multiple policy classes and interfaces. Additionally, minor formatting corrections were made to SQL query strings in various scripts and notebooks to ensure proper syntax.

Changes

Files Change Summary
.github/workflows/analysis.yml Replaced security scanning action and removed a parameter.
api/src/pdc/services/policy/actions/ListAction.ts Modified logic for checking operator UUID inclusion with fallback handling.
api/src/pdc/services/policy/actions/ListAction.unit.spec.ts Introduced unit tests for the ListAction class, validating the handle method under different conditions.
api/src/pdc/services/policy/engine/policies/20210520_IDFM.ts Added allTimeOperators property to IDFMPeriodeNormale2021 class for aggregated operator data.
api/src/pdc/services/policy/engine/policies/20240101_PaysDeLaLoire.ts Added allTimeOperators property to PaysDeLaLoire2024 class for aggregated operator data.
api/src/pdc/services/policy/interfaces/engine/PolicyInterface.ts Introduced optional allTimeOperators property in PolicyHandlerParamsInterface.
api/src/shared/policy/common/interfaces/PolicyInterface.ts Added optional allTimeOperators property to PolicyInterface.
notebooks/scripts/distance_duration_anomalycheck.py Corrected SQL update query string syntax.
notebooks/scripts/notebooks/distance_duration_anomalycheck.ipynb Adjusted SQL update query string syntax.
notebooks/scripts/notebooks/temporal_overlap_anomalycheck.ipynb Adjusted SQL update query string syntax.
notebooks/scripts/temporal_overlap_anomalycheck.py Corrected SQL update query string syntax.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CI/CD
    participant SecurityScanner
    participant PolicyHandler

    User->>CI/CD: Push changes
    CI/CD->>SecurityScanner: Trigger security scan
    SecurityScanner-->>CI/CD: Return scan results
    CI/CD->>PolicyHandler: Execute policy actions
    PolicyHandler-->>CI/CD: Return policy results
    CI/CD-->>User: Notify results

🐰 "In the meadow, changes bloom,
New paths for policies to zoom.
Operators gathered, all in line,
A safer world, oh how divine!
With tests to keep our code so bright,
Hoppy days are now in sight!" 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.