betagouv / rdv-service-public

Prise de RDV pour les services publics
https://rdv.anct.gouv.fr
GNU Affero General Public License v3.0
12 stars 2 forks source link

Corriger erreur nil renvoyée par Oauth2 #4403

Open sentry-sentry-incubateur-net[bot] opened 2 days ago

sentry-sentry-incubateur-net[bot] commented 2 days ago

Le problème semble venir de cette ligne https://github.com/omniauth/omniauth_openid_connect/blob/4957d977b61db217d7cbf57d123cdee819810805/lib/omniauth/strategies/openid_connect.rb#L131

le e.response[:error] de Rack::OAuth2 semble être nil

Nous avons pas mal de retard de versions sur plusieurs gems d’auth :

gem notre version dernière version
omniauth 2.1.2 à jour
omniauth_openid_connect 0.4.0 0.7.1
openid_connect 1.4.2 2.3.0
rack-oauth2 1.21.3 2.2.1

Sentry Issue: LAPINS-15W

Rack::OAuth2::Client::Error: Rack::OAuth2::Client::Error
  config/initializers/cookie_overflow_notify.rb:10:in `call'
    @app.call(env)
...
(229 additional frame(s) were not displayed)

NoMethodError: undefined method `to_sym' for nil (NoMethodError)

      env['omniauth.error.type'] = message_key.to_sym
                                              ^^^^^^^
  config/initializers/cookie_overflow_notify.rb:10:in `call'
    @app.call(env)
...
(227 additional frame(s) were not displayed)