search

betalgo / openai

OpenAI .NET sdk - Azure OpenAI, ChatGPT, Whisper, and DALL-E
https://betalgo.github.io/openai/
MIT License
2.89k stars 521 forks source link

Redundant Property: ToolCallId (always null) #474

Closed jameswilky closed 8 months ago

jameswilky commented 8 months ago

The ChatMessage object has a property called ToolCallId, however this property is always null. A tool call Is being returned by the API and is correctly being serialized in the ToolCalls list. Given a single message can return multiple tool calls, and the ID is unique to each call, it makes sense to remove this property from the ChatMessage object

Screenshot from 2024-01-11 16-02-48

kayhantolga commented 8 months ago

I found this https://platform.openai.com/docs/guides/function-calling/parallel-function-calling in the documentation and this https://community.openai.com/t/error-in-documentation-or-bug/491013/5 in the community forum. I can't remember if I ever used the value, but since it was added during the initial implementation and mentioned in the documentation, and it doesn't break anything, I prefer to leave it as is until it is completely removed from the documentation.