betamaxpy / betamax

A VCR imitation designed only for python-requests.
https://betamax.readthedocs.io/en/latest/
Other
565 stars 62 forks source link

Handle differences in Requests 2.11.0 #116

Closed sigmavirus24 closed 8 years ago

sigmavirus24 commented 8 years ago

Compare bodies appropriately by ensuring both the request body and the recorded body are coerced to bytestrings.

Closes #115 Closes #114

cc @bboe. This seems to pass with your regression test on both Requests 2.10.0 and 2.11.0. I'd love your review

bboe commented 8 years ago

@sigmavirus24 this seems to work great. Very straightforward solution. Thanks for promptly working on it.