Raise BetamaxError on unknown and invalid options.

betamaxpy / betamax

A VCR imitation designed only for python-requests.

https://betamax.readthedocs.io/en/latest/

Other

565 stars 62 forks source link

Raise BetamaxError on unknown and invalid options. #118

Closed bboe closed 8 years ago

bboe commented 8 years ago

Resolves #117.

sigmavirus24 commented 8 years ago

I'm concerned that using just BetamaxError will be not very user friendly. So I think I want us to set up an exception hierarchy here:

ValidationError would inherit from BetamaxError
- Then you could have InvalidOption inherit from ValidationError so we raise this if the key is not a valid configuration option (L88 in your diff of betamax/options.py)
- And a dictionary of exceptions that map from key to exception, e.g., match_requests_on to MatchersValidationError. We then get and raise an exception specific to what we're validating.

How does that sound to you?

bboe commented 8 years ago

@sigmavirus24 Hierarchy added. Doing a few force pushes to fix those few pesky py2.6 assertion method not found errors.

bboe commented 8 years ago

Looks like the py2.6 issues have been resolved, and none of the travis builds have failed yet, so I don't see any reason why it would on the next.

Thanks for the feedback!

bboe commented 8 years ago

@sigmavirus24 thanks for the feedback. I will address the method by which those assertions happen this weekend, as I will be away from the keyboard until then, and unfortunately don't have the five minutes needed to fix it right now.

sigmavirus24 commented 8 years ago

@bboe don't worry about it then. I'll take care of them tonight or tomorrow morning.

bboe commented 8 years ago

Thanks!