Closed bboe closed 8 years ago
I'm concerned that using just BetamaxError
will be not very user friendly. So I think I want us to set up an exception hierarchy here:
ValidationError
would inherit from BetamaxError
InvalidOption
inherit from ValidationError
so we raise this if the key is not a valid configuration option (L88 in your diff of betamax/options.py
)match_requests_on
to MatchersValidationError
. We then get and raise an exception specific to what we're validating.How does that sound to you?
@sigmavirus24 Hierarchy added. Doing a few force pushes to fix those few pesky py2.6 assertion method not found errors.
Looks like the py2.6 issues have been resolved, and none of the travis builds have failed yet, so I don't see any reason why it would on the next.
Thanks for the feedback!
@sigmavirus24 thanks for the feedback. I will address the method by which those assertions happen this weekend, as I will be away from the keyboard until then, and unfortunately don't have the five minutes needed to fix it right now.
@bboe don't worry about it then. I'll take care of them tonight or tomorrow morning.
Thanks!
Resolves #117.