search

betamaxpy / betamax

A VCR imitation designed only for python-requests.
https://betamax.readthedocs.io/en/latest/
Other
565 stars 62 forks source link

Added support for unittest2 testing framework #120

Closed nobodyguy closed 7 years ago

nobodyguy commented 7 years ago

What do you think?

sigmavirus24 commented 7 years ago

Is this not just a copy-paste of the existing unittest integration with almost no changes and no tests?

Why wouldn't we include this in our existing unittest integration? For example, 

try:
    import unittest2 as unittest
except ImportError:
    import unittest
nobodyguy commented 7 years ago

Yes, it's basically copy&paste of current unittest implementation. I definitely like suggested solution more, I just wasn't sure which approach would you like more. I'll create another PR if you don't mind :-)