search

betamaxpy / betamax

A VCR imitation designed only for python-requests.
https://betamax.readthedocs.io/en/latest/
Other
565 stars 62 forks source link

Collaboration Guidelines #148

Open sigmavirus24 opened 6 years ago

sigmavirus24 commented 6 years ago

Let's chat collaboration guidelines.

Personally, I'd like everything to have at least one review from someone before it's merged but at the current time it's not entirely practical to block everything on my review.

How can we enable this going forward?

I think growing the team would be a good way of doing this. So that begs the question, how do we effectively grow the team?

hroncok commented 6 years ago

I can ask fellow colleagues and friends I know use Betamax whether they are interested. @MarekSuchanek @encukou

There is also 10 other people watching this repo who might speak up now if they read this.

I'll also cc @bboe because he's the second listed at https://github.com/betamaxpy/betamax/graphs/contributors and is not watching the repo.

MarekSuchanek commented 6 years ago

It would be a pleasure to join this interesting project although so far I'm just its user...

bboe commented 6 years ago

Thanks for pulling me in @hroncok. I'm happy to provide code reviews from time to time, but realistically that probably means one a month.

encukou commented 6 years ago

My time is similarly limited. I'd love to help, but I don't think I'll ever run out of code I should review, so my picking up a betamax review isn't very realistic :( If you ask me for a review specifically, though, I'll try to prioritize it.

sigmavirus24 commented 6 years ago

So, in general, I'd prefer that we not try to just rope in people with whom we're already friends. That usually excludes a much larger group of potentially awesome collaborators (who could then become friends and colleagues).

I fully understand that a lot of projects do this poorly, so I freely recognize that it will result in some growing pains. I don't want to force anyone into this though, so @MarekSuchanek shouldn't feel obligated to accept. I'm unfamiliar with Marek, so I'd love to see how they approach code reviews on existing PRs and interacting with users on open issues before adding them. I completely understand if there's little interest though in doing that.

As food for thought, the python-hyper project has a One of the Team. It's pretty easy to think about because there's very little process to becoming a team member.

hroncok commented 6 years ago

One of the Team sound great!