search

betamaxpy / betamax

A VCR imitation designed only for python-requests.
https://betamax.readthedocs.io/en/latest/
Other
567 stars 62 forks source link

Implement MockHTTPResponse.close #201

Closed iv-m closed 8 months ago

iv-m commented 1 year ago

https://github.com/betamaxpy/betamax/issues/200

jhatler commented 9 months ago

I merged #202, #205, and #206 on my fork and then rebased this commit onto them. I updated the commit slightly to pass the docstring checks. All of the tox checks pass in my build here:

https://github.com/jhatler/betamax/pull/6

Once #202, #205, and #206 are merge, I think this can be as well.

Once this is merged, #200 should be fixed as this project will be compatible with urllib3 v2.

IvanAnishchuk commented 8 months ago

Could this be a good time to revive this? Is any work still required before this can be merged?

sigmavirus24 commented 8 months ago

Could this be a good time to revive this? Is any work still required before this can be merged?

If @iv-m wants to rebase this I'd merge it. If someone else wants to resubmit on their behalf that's fine by me too

iv-m commented 8 months ago

If @iv-m wants to rebase this I'd merge it.

Done)

sigmavirus24 commented 8 months ago

0.9.0 has been released with this. Thank you @iv-m @jhatler