betamaxpy / betamax

A VCR imitation designed only for python-requests.

https://betamax.readthedocs.io/en/latest/

Other

566 stars 62 forks source link

Fixed flake8 docstring/PEP 257 for init and adapter #76

Closed itsmemattchung closed 8 years ago

itsmemattchung commented 8 years ago

Summary

Updated docstrings for pep257 compliance for __init__.py and adapter.py. If this looks good, will fix remaining docstrings in order for travis ci to pass

Output of pep257

(betamax)Matts-MacBook-Air:betamax mattchung$ pep257 betamax/__init__.py
(betamax)Matts-MacBook-Air:betamax mattchung$ pep257 betamax/adapter.py
(betamax)Matts-MacBook-Air:betamax mattchung$

sigmavirus24 commented 8 years ago

kicks Travis CI

sigmavirus24 commented 8 years ago

@itsmemattchung mind taking another pass over this? Ping me when you have because GitHub doesn't tell me when a PR is updated.

itsmemattchung commented 8 years ago

Thanks @sigmavirus24 will let you know once it has been updated.

itsmemattchung commented 8 years ago

@sigmavirus24 Still adjusting to the time zone difference, sorry it took a little longer than expected. Let me know what you think and if anything else should be updated in this PR

sigmavirus24 commented 8 years ago

There are some comments that it looks like you might have missed @itsmemattchung but I'm going to merge this. If you want to address those you can send further PRs. Thanks so much for this!

:cake:

itsmemattchung commented 8 years ago

hey @sigmavirus24 didn't realize I missed a couple of the comments. I'll take a closer look and send additional PL.