betamaxpy / betamax

A VCR imitation designed only for python-requests.
https://betamax.readthedocs.io/en/latest/
Other
566 stars 62 forks source link

tests/integration folder installed regardless of excluding #82

Closed felixonmars closed 8 years ago

felixonmars commented 8 years ago

This actually confused me and I don't understand why it is happening, but the whole tests/integration folder was copied and installed regardless of exclude=['tests'] in setup.py. setuptools here is at 18.5 (latest) version.

Some related logs:

running build
running build_py
creating build
creating build/lib
creating build/lib/betamax
copying betamax/configure.py -> build/lib/betamax
copying betamax/decorator.py -> build/lib/betamax
copying betamax/exceptions.py -> build/lib/betamax
copying betamax/options.py -> build/lib/betamax
copying betamax/recorder.py -> build/lib/betamax
copying betamax/__init__.py -> build/lib/betamax
copying betamax/adapter.py -> build/lib/betamax
creating build/lib/betamax/cassette
copying betamax/cassette/__init__.py -> build/lib/betamax/cassette
copying betamax/cassette/cassette.py -> build/lib/betamax/cassette
copying betamax/cassette/headers.py -> build/lib/betamax/cassette
copying betamax/cassette/interaction.py -> build/lib/betamax/cassette
copying betamax/cassette/mock_response.py -> build/lib/betamax/cassette
copying betamax/cassette/util.py -> build/lib/betamax/cassette
creating build/lib/betamax/fixtures
copying betamax/fixtures/__init__.py -> build/lib/betamax/fixtures
copying betamax/fixtures/pytest.py -> build/lib/betamax/fixtures
copying betamax/fixtures/unittest.py -> build/lib/betamax/fixtures
creating build/lib/betamax/matchers
copying betamax/matchers/__init__.py -> build/lib/betamax/matchers
copying betamax/matchers/base.py -> build/lib/betamax/matchers
copying betamax/matchers/body.py -> build/lib/betamax/matchers
copying betamax/matchers/digest_auth.py -> build/lib/betamax/matchers
copying betamax/matchers/headers.py -> build/lib/betamax/matchers
copying betamax/matchers/host.py -> build/lib/betamax/matchers
copying betamax/matchers/method.py -> build/lib/betamax/matchers
copying betamax/matchers/path.py -> build/lib/betamax/matchers
copying betamax/matchers/query.py -> build/lib/betamax/matchers
copying betamax/matchers/uri.py -> build/lib/betamax/matchers
creating build/lib/betamax/serializers
copying betamax/serializers/__init__.py -> build/lib/betamax/serializers
copying betamax/serializers/base.py -> build/lib/betamax/serializers
copying betamax/serializers/json_serializer.py -> build/lib/betamax/serializers
copying betamax/serializers/proxy.py -> build/lib/betamax/serializers
creating build/lib/tests
creating build/lib/tests/integration
copying tests/integration/__init__.py -> build/lib/tests/integration
copying tests/integration/helper.py -> build/lib/tests/integration
copying tests/integration/test_backwards_compat.py -> build/lib/tests/integration
copying tests/integration/test_fixtures.py -> build/lib/tests/integration
copying tests/integration/test_multiple_cookies.py -> build/lib/tests/integration
copying tests/integration/test_placeholders.py -> build/lib/tests/integration
copying tests/integration/test_preserve_exact_body_bytes.py -> build/lib/tests/integration
copying tests/integration/test_record_modes.py -> build/lib/tests/integration
copying tests/integration/test_unicode.py -> build/lib/tests/integration
...
sigmavirus24 commented 8 years ago

It's being included by MANIFEST.in. If I remember correctly, this was for downstream redistributors looking to distribute tests with the package. I'm very confused as to why this is being installed to site-packages though

sigmavirus24 commented 8 years ago

Ah the reason it is installed is because tests.integration is considered a separate package and needs to be added to the exclude for find_packages.

sigmavirus24 commented 8 years ago

@felixonmars do you need a new release with e53e416 included?

felixonmars commented 8 years ago

Not in a hurry, but a new release would be sweet :)