search

betatim / notebook-as-pdf

Save Jupyter Notebooks as PDF
BSD 3-Clause "New" or "Revised" License
370 stars 73 forks source link

Fix PDFWriter #41

Closed AleksandrTulenkov closed 1 year ago

AleksandrTulenkov commented 1 year ago

Fixing this issue: PdfFileWriter is deprecated and was removed in PyPDF2 3.0.0. Use PdfWriter instead. #40

betatim commented 1 year ago

Thanks for the PR! Can you please remove the unrelated changes (changing bookmark to outline item)?

AleksandrTulenkov commented 1 year ago

Thanks for the PR! Can you please remove the unrelated changes (changing bookmark to outline item)? It's also deprecated as I undestand.

Deprecated since version 1.28.0: Use add_outline_item() instead.

thomaspingel commented 1 year ago

Is there more left to do on this one? Happy to help.

AleksandrTulenkov commented 1 year ago

Looks like issue solved as I wrote about changing bookmark to outline item it's the same old ver deprecated stuff

betatim commented 1 year ago

Merged. Thanks for the work, I hadn't seen your reply explaining the outline thing.