search

betatim / notebook-as-pdf

Save Jupyter Notebooks as PDF
BSD 3-Clause "New" or "Revised" License
368 stars 72 forks source link

use embed_images=True for html export #44

Closed mortbauer closed 3 months ago

mortbauer commented 3 months ago

Closes #18

betatim commented 3 months ago

I will try and get to looking (and more time consumingly: thinking) about this in the next few days.

Thanks for being patient during all the days that have passed since you opened the PR!

betatim commented 3 months ago

This does look like a "no brainer" in terms of solution (of course someone else in jupyter land already had the same problem and fixed it :D)

Just to double check, did you try this code out and does it indeed fix the problem of embedding an image in a markdown cell that is referenced by a local file path (relative to the notebook)?

mortbauer commented 3 months ago

Yes sure it is a no brainer :), and yes it fixed it for me!!