search

betcode-org / betconnect

betconnect - API client
MIT License
7 stars 6 forks source link

betting.active_fixtures endpoint - start_date field #26

Closed BroomJack closed 2 years ago

BroomJack commented 2 years ago

The start_date field has the time always as 00:00. There is argument that it is just for the date, but it is a datetime data type and I can't see the harm in having the time here as well. Yes, there is a 'time' value, but it would make things easier if the time was correct in start_date. [Fixture: Eintracht Frankfurt v West Ham(9050623) 2022-05-05 00:00:00, Fixture: Rangers v RB Leipzig(9050622) 2022-05-05 00:00:00] fixture_id=9050623 display_name='Eintracht Frankfurt v West Ham' start_date=datetime.datetime(2022, 5, 5, 0, 0) time=datetime.time(20, 0) each_way_active=None ^ As you can see in both these examples, the time is 00:00:00 which is just wrong

varneyo commented 2 years ago

Have you looked at ActiveFixture.start_date_time?

BroomJack commented 2 years ago

Didn't know about this field. When doing a print of the object, all I saw were the start_date and time values so didn't think to look for it.

varneyo commented 2 years ago

Cool, always best to use the debugger rather print stuff I find