betcode-org / betconnect

betconnect - API client
MIT License
7 stars 6 forks source link

bet_request_get doesn't allow for each-way bets #38

Closed BroomJack closed 2 years ago

BroomJack commented 2 years ago

The issue here is that it forces the user to provide their input as a string which is incorrect data type for our API. This means that if the user attempts to get each-way bets, they are always given a 400 error from our API complaining about the each_way_active value being invalid. If the user then doesn't supply this filter parameter, by default they are constrained to non-each-way bets only.

I propose that because this parameter represents a boolean, the user should provide either a True or False boolean value. From here the wrapper will handle this to make the correct calls to the API.

BroomJack commented 2 years ago

Fixed by pull-request #39