Remove unnecessary conversion of dict values to list

[petedmarsh]

As {}.values() is already iterable there's no need to conver them to a list:

d = {'a': 1, 'b': 2}
a = [n for n in list(d.values())]
b = [n for n in d.values()]

a == b  # True

[liampauling]

Agreed but this is done on purpose to give the output a new object with no references to the cache which is going to be constantly updated by another thread, unless values has been updated in python to give a new object rather than a pointer?

[liampauling]

And you can see the error in the tests proving it

[petedmarsh]

Ah, yes of course.

It may be slightly more performant to iterate over the market_ids if set, I will bench mark and see.