betcode-org / betfair

betfairlightweight - Betfair API-NG python wrapper (with streaming)
MIT License
419 stars 147 forks source link

close #550 #563

Closed liampauling closed 4 months ago

liampauling commented 4 months ago

update create socket for py3.12

synapticarbors commented 4 months ago

I think you need to add setuptools as an explicit dependency. You might also consider moving to a more modern setup using a pyproject.toml with a build-system defined: https://packaging.python.org/en/latest/guides/writing-pyproject-toml/ https://packaging.python.org/en/latest/guides/modernize-setup-py-project/

liampauling commented 4 months ago

Yeah that isn't a concern re this change

synapticarbors commented 4 months ago

I agree, that moving to a different build system is secondary, but I think you do need to add setuptools to your build environment. See https://docs.python.org/3/whatsnew/3.12.html and under "Important deprecations, removals or restrictions" -> gh-95299