betfair / aping-ios-sdk

iOS SDK for APING
Other
4 stars 9 forks source link

API stopped to work #3

Closed galfaroth closed 10 years ago

galfaroth commented 10 years ago

BNGAccountDetails has all values nulled. The ios.betfair.api doesn't respond anymore...

seanoshea commented 10 years ago

@galfaroth Will take a look at this ASAP. Have you registered your own app key for the developer program?

galfaroth commented 10 years ago

Not sure about that but in the past i needed to register sth in order for it to work. I came back to the code after few weeks and i couldnt connect to the api. 

— Sent from Mailbox for iPhone

On Wed, Feb 12, 2014 at 5:32 PM, seanoshea notifications@github.com wrote:

@galfaroth Will take a look at this ASAP. Have you registered your own app key for the developer program?

Reply to this email directly or view it on GitHub: https://github.com/betfair/aping-ios-sdk/issues/3#issuecomment-34886607

seanoshea commented 10 years ago

OK - would you mind emailing me your app key. I'm Sean.OShea@betfair.com. I can check and see if there's anything wrong with the key.

seanoshea commented 10 years ago

Closing this. If there are any issues in relation to your application key, please see https://bdp.betfair.com/

galfaroth commented 10 years ago

Hi Sean, That still does not work… I don’t think it was an answer to the problem...

Best, Piotr

Piotr Szwach Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Monday, February 17, 2014 at 10:19 PM, seanoshea wrote:

Closing this. If there are any issues in relation to your application key, please see https://bdp.betfair.com/

— Reply to this email directly or view it on GitHub (https://github.com/betfair/aping-ios-sdk/issues/3#issuecomment-35323838).

seanoshea commented 10 years ago

100% our fault here. The quick fix is to add a trailing slash to the end of the account API call:

staging-mbp-3:aping-ios-sdk osheas$ git diff "APING iOS SDK/Categories/NSURL+APING.m"
diff --git a/APING iOS SDK/Categories/NSURL+APING.m b/APING iOS SDK/Categories/NSURL+APING.m
index a0a7f13..0344f6a 100644
--- a/APING iOS SDK/Categories/NSURL+APING.m    
+++ b/APING iOS SDK/Categories/NSURL+APING.m    
@@ -92,7 +92,7 @@ NSString *const BNGAPIVersion       = @"1.0";
     NSParameterAssert(operation.length);

     if (operation.length) {
-        return [NSURL URLWithString:[NSString stringWithFormat:@"%@/account/rest/v%@/%@",
+        return [NSURL URLWithString:[NSString stringWithFormat:@"%@/account/rest/v%@/%@/",
                                      BNGBaseURLString,
                                      BNGAPIVersion,
                                      operation]];
staging-mbp-3:aping-ios-sdk osheas$ 

I'll update the library ASAP. Thanks again for the bug report.

galfaroth commented 10 years ago

Damn great! Now working perfectly!

Best, Piotr

Piotr Szwach Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Wednesday, February 19, 2014 at 10:36 PM, seanoshea wrote:

Reopened #3 (https://github.com/betfair/aping-ios-sdk/issues/3).

— Reply to this email directly or view it on GitHub (https://github.com/betfair/aping-ios-sdk/issues/3).

seanoshea commented 10 years ago

Closing as this was fixed in 6cffdeeefb183669edb06dfb50488d892f56c07a