search

betfair / cougar

Cougar is a framework for making building network exposed service interfaces easy.
http://betfair.github.io/cougar
Apache License 2.0
27 stars 18 forks source link

Cleanup zipkin transport dependencies #102

Open eswdd opened 9 years ago

eswdd commented 9 years ago

Currently inclusion of zipkin triggers inclusion of socket and jetty transports. This is bad for clients and less than ideal for servers. Additionally whilst we can exclude dependencies, certain config will fail if we do (for example socket port which if socket transport not included will fail to parse to an int and throw and exception at start).

This needs resolving prior to 3.3 release.

HugoMFernandes commented 8 years ago

Hey Simon,

Can you elaborate on this so I know what needs to be picked up? A list of things that really need solving before a 3.3 release would be helpful.

Cheers.

eswdd commented 8 years ago

Hi Hugo There's not much more to say except what's in the description. If you're using the Cougar client in another app then you pull in minimal dependencies. If you then want Zipkin support in that client, then inclusion of the cougar-zipkin dependency pulls in far more - this we don't want. I haven't looked further to see how best to solve. This is the only blocker for a 3.3 release AFAIK.

andredasilvapinto commented 8 years ago

https://github.com/betfair/cougar/pull/103