betfair / cougar

Cougar is a framework for making building network exposed service interfaces easy.
http://betfair.github.io/cougar
Apache License 2.0
27 stars 18 forks source link

Fix #102 - Split Zipkin code into multiple maven modules. #103

Closed andredasilvapinto closed 8 years ago

andredasilvapinto commented 8 years ago

So we can include more limited dependencies into the projects that use it.

E.g.:

<dependency>
  <groupId>com.betfair.cougar</groupId>
  <artifactId>cougar-zipkin-server-http</artifactId>
  <version>${cougar.version}</version>
</dependency>

<dependency>
  <groupId>com.betfair.cougar</groupId>
  <artifactId>cougar-zipkin-client-http</artifactId>
  <version>${cougar.version}</version>
</dependency>

for HTTP support, plus importing the resources to Spring's Application Context:

<import resource="classpath:conf/cougar-zipkin-server-http.xml"/>
<import resource="classpath:conf/cougar-zipkin-client-http.xml"/>

Tested by @HugoMFernandes

eswdd commented 8 years ago

Looks sane on phone. Travis build due to other issues failed so will merge manually and review more thoroughly...

eswdd commented 8 years ago

Would it be safe to assume you want a release cut after this?

andredasilvapinto commented 8 years ago

hey Simon, for me it isn't really relevant, I just wanted to help finish the Zipkin feature, as it would be a waste to have it unfinished just because of this.

eswdd commented 8 years ago

Ah yes, sorry, I'd forgotten you've left Betfair. On 19 Mar 2016 12:26, "André Pinto" notifications@github.com wrote:

hey Simon, for me it isn't really relevant, I just wanted to help finish the Zipkin feature, as it would be a waste to have it unfinished just because of this.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/betfair/cougar/pull/103#issuecomment-198694032

HugoMFernandes commented 8 years ago

We still have a couple of services running cougar 3, so we could use a release cut. Thanks @andredasilvapinto for finishing this.