search

betfair / cougar

Cougar is a framework for making building network exposed service interfaces easy.
http://betfair.github.io/cougar
Apache License 2.0
27 stars 18 forks source link

Negatively cache missing deserializers in binary transport (Issue 53). #54

Closed atropineal closed 10 years ago

atropineal commented 10 years ago

Introduces a 'missing type' cache to prevent a performance issue when clients get data items from the server pertaining to types that weren't in the IDD the client was compiled against.

Implementation of #53

eswdd commented 10 years ago

James, can you take a look at the tests for this - they seem to be failing on both JDKs..

atropineal commented 10 years ago

Hey Simon,

One of the tests times optimized vs un-optimized and asserts than the optimized is at least 10x faster than the other. On my node it's about 25x faster, but I noticed on AHP I got intermittent fails. Due to shared resources I guess. I will probably just @Ignore or delete that test sometime tomorrow.

Best regards,

James

On Wed, Nov 20, 2013 at 11:32 PM, Simon Matic Langford < notifications@github.com> wrote:

James, can you take a look at the tests for this - they seem to be failing on both JDKs..

— Reply to this email directly or view it on GitHubhttps://github.com/betfair/cougar/pull/54#issuecomment-28933107 .

eswdd commented 10 years ago

Yeah, sounds like an unsafe test. Once you've decided what to do, just update this request with the commit and I'll accept it tomorrow.

Cheers Simon