betfair / cougar

Cougar is a framework for making building network exposed service interfaces easy.
http://betfair.github.io/cougar
Apache License 2.0
27 stars 18 forks source link

Upgrade Jetty to >= 9.1 #95

Closed andredasilvapinto closed 9 years ago

andredasilvapinto commented 9 years ago

so we can expose Jetty's QTP queue size.

Jetty 9.2.6 has it: http://download.eclipse.org/jetty/9.2.6.v20141205/apidocs/org/eclipse/jetty/util/thread/QueuedThreadPool.html#getQueueSize%28%29

Jetty 9.0.6 (Cougar's version) doesn't: http://archive.eclipse.org/jetty/9.0.6.v20130930/apidocs/org/eclipse/jetty/util/thread/QueuedThreadPool.html

If we don't want to migrate to the very latest Jetty version, we can pick any >= 9.1 version, as this functionality was introducted in 9.1.0: http://archive.eclipse.org/jetty/9.1.0.v20131115/apidocs/org/eclipse/jetty/util/thread/QueuedThreadPool.html#getQueueSize%28%29

eswdd commented 9 years ago

I have no objection to moving straight to 9.2.6

We're only on 9.0.6 as that was the latest version when we last updated all the library versions.

On 20 January 2015 at 11:38, André Pinto notifications@github.com wrote:

so we can expose Jetty's QTP queue size.

Jetty 9.26 has it:

http://download.eclipse.org/jetty/9.2.6.v20141205/apidocs/org/eclipse/jetty/util/thread/QueuedThreadPool.html#getQueueSize%28%29

Jetty 9.0.6 (Cougar's version) doesn't:

http://archive.eclipse.org/jetty/9.0.6.v20130930/apidocs/org/eclipse/jetty/util/thread/QueuedThreadPool.html

If we don't want to migrate to the very latest Jetty version, we can pick any >= 9.1 version, as this functionality was introducted in 9.1.0:

http://archive.eclipse.org/jetty/9.1.0.v20131115/apidocs/org/eclipse/jetty/util/thread/QueuedThreadPool.html#getQueueSize%28%29

— Reply to this email directly or view it on GitHub https://github.com/betfair/cougar/issues/95.

eswdd commented 9 years ago

Started this am - jars a bit slow to load on a fast train. Latest is now 9.2.7 so have used that. Some minor api diffs which shouldnt be problematic and then will see how tests do.. On 20 Jan 2015 13:50, "Simon Matic Langford" simon@exemel.co.uk wrote:

I have no objection to moving straight to 9.2.6

We're only on 9.0.6 as that was the latest version when we last updated all the library versions.

On 20 January 2015 at 11:38, André Pinto notifications@github.com wrote:

so we can expose Jetty's QTP queue size.

Jetty 9.26 has it:

http://download.eclipse.org/jetty/9.2.6.v20141205/apidocs/org/eclipse/jetty/util/thread/QueuedThreadPool.html#getQueueSize%28%29

Jetty 9.0.6 (Cougar's version) doesn't:

http://archive.eclipse.org/jetty/9.0.6.v20130930/apidocs/org/eclipse/jetty/util/thread/QueuedThreadPool.html

If we don't want to migrate to the very latest Jetty version, we can pick any >= 9.1 version, as this functionality was introducted in 9.1.0:

http://archive.eclipse.org/jetty/9.1.0.v20131115/apidocs/org/eclipse/jetty/util/thread/QueuedThreadPool.html#getQueueSize%28%29

— Reply to this email directly or view it on GitHub https://github.com/betfair/cougar/issues/95.

andredasilvapinto commented 9 years ago

Great. Having visibility of the QTP queue size is a useful feature in the Betfair context.

eswdd commented 9 years ago

Hitting some probs with our integration tests. Will play for a bit otherwise will try dropping back a bit... On 21 Jan 2015 09:42, "André Pinto" notifications@github.com wrote:

Great. Having visibility of the QTP queue size is a useful feature in the Betfair context.

— Reply to this email directly or view it on GitHub https://github.com/betfair/cougar/issues/95#issuecomment-70809431.

eswdd commented 9 years ago

9.2.7 proved problematic, so rather than hunt for a working 9.2.x release i've gone back to 9.1.5 which passed all tests locally. On 22 Jan 2015 08:47, "Simon Matic Langford" simon@exemel.co.uk wrote:

Hitting some probs with our integration tests. Will play for a bit otherwise will try dropping back a bit... On 21 Jan 2015 09:42, "André Pinto" notifications@github.com wrote:

Great. Having visibility of the QTP queue size is a useful feature in the Betfair context.

— Reply to this email directly or view it on GitHub https://github.com/betfair/cougar/issues/95#issuecomment-70809431.

andredasilvapinto commented 9 years ago

:+1: this is much valued here. Will try it locally on SEAS today.

eswdd commented 9 years ago

Tests all passing on travis