search

betfair / stream-api-sample-code

Sample code for the exchange stream api which provide real time market and order data from betfair.
73 stars 60 forks source link

MarketChangeMessage and OrderChangeMessage Id and Op not overriding Change message properties #18

Open WookerEmUp opened 3 years ago

WookerEmUp commented 3 years ago

I'm not sure if this is intended behaviour, the way swagger creates definitions or an oversight, but is there a reason for this.

Derived classes Betfair.ESASwagger.Model.MarketChangeMessage and Betfair.ESASwagger.Model.OrderChangeMessage hide both Id and Op properties from Betfair.ESASwagger.Model.ChangeMessage. With the demo code it doesn't cause any issue, however extending the behaviour of the code does through some unintended behaviour.

Thanks Wook

davezeetone commented 3 years ago

MarketSubscription in RequestResponseProcessor overrides custom id with next default id. looks like it is just to prevent conflicting ids and we will have to sort it out ourselves