search

bethatkinson / rpart

Recursive Partitioning and Regression Trees
46 stars 24 forks source link

Fix bug in prune.rpart.R #29

Closed bquistorff closed 3 years ago

bquistorff commented 3 years ago

This fixes a bug in prune.rpart.R (https://github.com/bethatkinson/rpart/issues/4 and https://github.com/bethatkinson/rpart/issues/26) that can cause an index out of bounds error when the cptable[1,] has duplicate values.

bethatkinson commented 3 years ago

thank you!

From: Brian Quistorff @.> Sent: Wednesday, August 11, 2021 12:28 PM To: bethatkinson/rpart @.> Cc: Subscribed @.***> Subject: [EXTERNAL] [bethatkinson/rpart] Fix bug in prune.rpart.R (#29)

This fixes a bug in prune.rpart.R (#4https://github.com/bethatkinson/rpart/issues/4 and #26https://github.com/bethatkinson/rpart/issues/26) that can cause an index out of bounds error when the cptable[1,] has duplicate values.

You can view, comment on, or merge this pull request online at:

https://github.com/bethatkinson/rpart/pull/29

Commit Summary

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/bethatkinson/rpart/pull/29, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACWQG54K4QNJCTJ2N24X7X3T4KXNXANCNFSM5B7BTWOA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.

vgherard commented 2 years ago

Hello there, Thanks for the cool package!

This fix doesn't appear to be in the published CRAN version, did you eventually choose against it?

I just ran into the exact same bug and found this is fixing my problem, just to let you know.

Valerio

bethatkinson commented 2 years ago

I just submitted a bunch of changes to cran this week so it should show up shortly.

From: Valerio Gherardi @.> Sent: Friday, January 28, 2022 1:59 AM To: bethatkinson/rpart @.> Cc: Atkinson, Elizabeth J. (Beth), M.S. @.>; State change @.> Subject: [EXTERNAL] Re: [bethatkinson/rpart] Fix bug in prune.rpart.R (#29)

Hello there, Thanks for the cool package!

This fix doesn't appear to be in the published CRAN version, did you eventually choose against it?

I just ran into the exact same bug and found this is fixing my problem, just to let you know.

Valerio

— Reply to this email directly, view it on GitHubhttps://github.com/bethatkinson/rpart/pull/29#issuecomment-1023971952, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACWQG55RS45K5X42BUSGYZLUYJEFPANCNFSM5B7BTWOA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you modified the open/close state.Message ID: @.***>